Re: [ros-dev] [ros-diffs] [dgorbachev] 26482: Use allocation function instead of hack, save 12 bytes.

[Alex Ionescu]

You are just getting lucky. Thomas is right, builtin_alloca does NOT
guarantee alignment.

-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of hto(a)mail.cnt.ru
Sent: April-24-07 12:19 AM
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [dgorbachev] 26482: Use allocation
function instead of hack, save 12 bytes.

Hi,

>   This change is *wrong*. It won't guarantee the
> correct alignment!!! 
@ExfAcquirePushLockShared@4():
ntoskrnl/ex/pushlock.c:611
     push   %ebp
     mov    %esp,%ebp
     push   %edi
     push   %esi
     push   %ebx
     sub    $0x4c,%esp
     mov    %ecx,0xffffffec(%ebp)
ntoskrnl/ex/pushlock.c:612
     mov    (%ecx),%edi
ntoskrnl/ex/pushlock.c:615
     lea    0xf(%esp),%esi
->  and    $0xfffffff0,%esi
ntoskrnl/ex/pushlock.c:621
     ...
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev