[ros-dev] Doubts about the header changes in r29178

[Colin Finck]

Hello,

Hervé added some Standard C library headers to the "include/crt" directory
in r29178.
Now some people noticed that these changes broke building ReactOS components
with MSVC using the ReactOS headers ("Debug - ReactOS headers" or "Release
-
ReactOS headers" configuration).

I have some general doubts about these changes.
>  From my knowledge, the headers added in this commit,
> are compiler-specific 
and target-independent. You can easily see that they are
specific to
GCC/mingw as for example "stdio.h" includes a "_mingw.h" file with
mingw-specific stuff.
"stdarg.h" even leads to compilation problems with non-GCC-compilers (like
MSVC), because it defines a type based on the __builtin_va_list type, and
this built-in type only exists for GCC.

In my opinion, this commit should be reverted.
This way every compiler will use its own Standard C library headers and MSVC
should be able to build ReactOS components using the ReactOS Win32 headers
again.

Regards,

Colin