Re: [ros-dev] [ros-diffs] [cfinck] 28423:-Alwaysinclude"wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the firstinc

[Colin Finck]

>   Ged wrote:
>  
>  Colin Finck wrote:
>  
> >   > I guess its using a define in the makefile
> > for _WCHAR_T  
>  generated by
> >   > configure or something. 
>  
> >   Might be possible, but I don't see this as a
> > good solution. 
>  
>  It's a better solution than what you changed. 
But it's not very intelligent, when we need to add more definitions. This
would require changing all Makefiles, which do it this way.
By putting the check into "winnt.h", we have a centralized place, where this
would need to be changed.

By the way, what are the rules for this Wine imported code?
Can we only change the Makefile or also make minor changes to the code?
Cause I think, another solution might be adding a ReactOS-specific header at
the top of each source file, which then takes care of this wchar_t thing.


>   I've been chatting to Hervé about this and here
> are at least 
>  3 potential ways to fix this:
>  
>  - change our wchar_t check to detect Mac OS X hosts 
What do you mean by "our wchar_t check"?
In my opinion, our wchar_t check is in "winnt.h" and there I changed it for
Mac OS X.


>   - add a ros-specific ctype.h 
This probably leads to problems as every host might need an own "ctype.h".
Remember that "ctype.h" also defines other types, not just wchar_t. And some
of our host applications probably need these types defined correctly, so
they work on this particular host.

Of course, we could add lots of host checks to our "ctype.h", but in my
opinion, this is a huge overkill and difficult to maintain.


>   - change the makefile to add the required stuff : 
>       ifeq (${PLATFORM}, MACOSX)  *mac stuff* 
Not a good solution if this needs to be changed in every Makefile...

Regards,

Colin