Hartmut Birr wrote:
ion@svn.reactos.com wrote:
Dmitry Philippov shedon@mail.ru:
- Implemented FindFirstFileExW() and have removed InternalFindFirstFile() in /lib/kernel32/file/find.c, now FindFirstFileA (), FindFirstFileExA () and FindFirstFileW called FindFirstFileExW ()
NOTE: Filip has asked revision "16661" (the next one) to be done by him... sorry if this sounds silly, but please respect his wish :)
Updated files: trunk/reactos/lib/kernel32/file/find.c
Ros-svn mailing list Ros-svn@reactos.com http://reactos.com:8080/mailman/listinfo/ros-svn
The implemention of FindFirstFileExW is very buggy. On errors, the allocated buffers are not cleanup correctly. The fourth parameter is wrong in the call to RtlDosPathNameToNtPathName_U. It isn't possible to cast a unicode string to a directory structure. The using of the results from the call to RtlDosPathNameToNtPathName_U is wrong. The buffer from the returned directory structure isn't always null terminated.
- Hartmut
Hi,
Does Dmity's new patch fix these issues?
Best regards, Alex Ionescu