Wasn't that kindof what Thomas' reply was all about? Well, he might have had a different reason to write "==" below the lines in question, maybe as a short text separator. XD
Am 19.04.2014 15:57, schrieb Pierre Schweitzer:
Hey! That's indeed a typo! Can someone commit a fix? I can't before Monday evening. Thanks!
Pierre
-------- Message original -------- Objet : Re: [ros-dev] [ros-diffs] [pschweitzer] 62779: [CDFS] Convert FCB pathname from simple buffer to unicode string. Please carefully review if I missed something De : Alexander Andrejevic theflash@sdf.lonestar.org À : ReactOS Development List ros-dev@reactos.org Cc :
Hi,
Correct me if I'm wrong, but the original version didn't modify the string length. Are you sure that should be "=" and not "=="?
Regards, Alex
On Sat, Apr 19, 2014 at 09:31:44AM +0200, Thomas Faber wrote:
On 2014-04-18 23:40, pschweitzer@svn.reactos.org wrote:
--- trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] Fri Apr 18 21:40:02 2014 @@ -129,7 +131,7 @@ BOOLEAN CdfsFCBIsRoot(PFCB Fcb) {
- return(wcscmp(Fcb->PathName, L"\") == 0);
- return (Fcb->PathName.Length = sizeof(WCHAR) && Fcb->PathName.Buffer[0] == L'\');
}
==
Generally I'm seeing a lot of manual work where RtlInitEmptyUnicodeString and RtlCopyUnicodeString could be used.
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev