Re: [ros-dev] [ros-diffs] [jgardou] 50991: [NTOSKRNL] - Print supported CPU features. - Simplify detection of non working but claimed SYSENTER support for intel processors - Workaround a virtualbox "feature" : claim that SY...

[Timo Kreuzer]

Am 07.03.2011 14:33, schrieb [e-mail]:
> Author: jgardou
> Date: Mon Mar  7 13:33:10 2011
> New Revision: 50991
> ...
>            Reg[3] |= 0x800;
>
> ...
>        if ((Reg[0]&  0x0FFF3FFF)<  0x00000633)

I'd prefer symbolic constants over these magic numbers.
> DPRINT1("Supported CPU features :\n");
>
> +#define print_supported(kf_value) \
> if(FeatureBits&  kf_value) DPRINT1("\t" #kf_value "\n")
> print_supported(KF_V86_VIS);
> print_supported(KF_RDTSC);
> print_supported(KF_CR4);
> print_supported(KF_CMOV);
> print_supported(KF_GLOBAL_PAGE);
> print_supported(KF_LARGE_PAGE);
> print_supported(KF_MTRR);
> print_supported(KF_CMPXCHG8B);
> print_supported(KF_MMX);
> print_supported(KF_WORKING_PTE);
> print_supported(KF_PAT);
> print_supported(KF_FXSR);
> print_supported(KF_FAST_SYSCALL);
> print_supported(KF_XMMI);
> print_supported(KF_3DNOW);
> print_supported(KF_AMDK6MTRR);
> print_supported(KF_XMMI64);
> print_supported(KF_DTS);
> print_supported(KF_NX_BIT);
> print_supported(KF_NX_DISABLED);
> print_supported(KF_NX_ENABLED);
>
> +#undef print_supported

Can we make this more compact please? Like "Supported CPU features: 
V86_VIS, RDTSC ..."

Thanks,
Timo