Re: [ros-dev] [ros-diffs] [hyperion] 41421: modified dll/win32/srclient/srclient_main.c What the hell, Arch Blackmann? <windef.h>, <winbase.h> and <winnls.h> are not meant to be included directly. Include <windows.h> instead modified drivers/video/font/ftfd/rosglue.c Move standard C includes before Windows includes, so the required types are defined beforehand modified include/crt/_mingw.h Re-add Visual C++ support va_list is not a built-in type, it does not belong in _mingw.h Do not include intrin.h (screw

[Timo Kreuzer]

[e-mail] wrote:
> Author: hyperion
> Date: Tue Jun 16 04:24:26 2009
> New Revision: 41421
>
> URL: http://svn.reactos.org/svn/reactos?rev=41421&view=rev
> Log:
> modified   dll/win32/srclient/srclient_main.c
>    What the hell, Arch Blackmann? <windef.h>, <winbase.h> and <winnls.h> are not meant to be included directly. Include <windows.h> instead
>
> modified   drivers/video/font/ftfd/rosglue.c
>    Move standard C includes before Windows includes, so the required types are defined beforehand
>
> modified   include/crt/_mingw.h
>    Re-add Visual C++ support
>    va_list is not a built-in type, it does not belong in _mingw.h
>    Do not include intrin.h (screw you, Arch)
>    Removed definition of _USE_32BIT_TIME_T ("ROS HACK!")
>
> modified   include/crt/conio.h
> modified   include/crt/stdio.h
> modified   include/crt/wchar.h
>    Pull in va_list from stdarg.h

In recent ms crt headers, va_list is defined in crtdefs.h, so it's
defined by all headers. This might not fit ANSI C, but that's what ms
does. So for compatibility reasons we might want to do it the same way(?)