Re: [ros-dev] [ros-diffs] [akhaldi] 60074: [WINE/TEST] * Introduce a way to properly mark the todos instead of counting them as failures. Brought to you by Thomas Faber.

[Jérôme Gardou]

Hi James,

I agree that this doesn't make sense for our in-house modules (WIN32 
subsystem, kernel32, ntdll, you name it...), but this should be used for 
modules that we import from wine, thus permitting us to clearly 
differentiate between features that wine doesn't implement and failed 
tests that fail because of a bug in our underlying modules.

This is not cheating, this is pinpointing issues are ours, and where 
they are wine's.

Regards
Jérôme

James Tabor a écrit :
>   Hi.
>
>  This should be removed, we are not wine and I personally work "hard on"
>  getting wine todos fixed in ReactOS! This also breaks the DCE test.
>
>
>  Background, GvG and then the old guard back in the day thought the same
>  way as I do about this issue. We should count the todo's as failures and
>  not bypass these failues. Why? It may point to a critical bug that could
>  break functionality somewhere else. That was the reasoning then and I
>  agree with it. Cheating the tests is just plain cheating......
>
>
>  James
>
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>