Yes, it is indeed a ridiculous analogy. I believe there are too many
advantages to have a unified place to have most of the common icons
usable by any app that needs them.
Note that my idea was for common icons, thing such the usual "objects"
(document icon, folder icon, the configuration cogs, warning triangle,
...) and "actions" (document-new, search, navigate-back/dorward,
zoom-in/out, ...).
I believe this ADDS to modularization, since it removes duplicate
copies of icons and unifies them in a more manageable way, while most
people who work on code are going to download most of ReactOS AND
RosTests either way, because it's not that useful with just the
kernel. ;P
I do admit that it has one bigger side-effect: if someone wants to
"move out" a single module/app away from the rest of the repository,
they'd have to select the required icons manually, but this does not
happen very often and it shouldn't really be bothering us. If a lot of
people are taking pieces of ReactOS and moving them elsewhere, this is
a sign of bad things.
On 24 July 2015 at 10:18, Ged Murphy <gedmurphy.maillists(a)gmail.com> wrote:
I like the idea in general, but there must be a
cleaner and more modular way
of doing it instead of dumping everything in one location.
In an area where many devs are pushing to modularize things (think current
win32ss and future minwin), this moves the tree in the opposite direction.
If you were a kernel and win32ss guy, you’d then need to have all the icons
for the whole OS in your WC just to build the area you’re interested in.
This is a kinda ridiculous analogy, but imagine if you had to checkout KDE
just to build the linux kernel.
Ged.
From: Ros-dev [mailto:ros-dev-bounces@reactos.org] On Behalf Of Jared Smudde
Sent: 24 July 2015 02:39
To: ros-dev(a)reactos.org
Subject: [ros-dev] Unify system icons into one central folder
Hello. I am Jared Smudde aka. Pi_User5. I propose that we move most of the
icons in trunk into a central folder in the media folder. Some icons will
need to stay because they might be application specific. The folder can be
called icons and it would be organized according to
http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.h….
This way, we can eliminate duplicate icons thus making trunk slightly
smaller. It will also make changing ReactOS to a different icon theme much
easier. This idea was suggested by gigaherz and I would like to see it done.
Thanks!
Jared
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev