Alex Ionescu wrote:
Hey,
Yes I was in a hurry, sorry.
- a. Modifying a well known, Microsoft-documented structure. b. Using structure-based bit logic instead of shifts and masks.
- a. I think this is clear. b. I think it makes the code less maintainable, harder to
understand, less clean, and potentially hurts performance. This becomes a significantly bigger problem when thinking about other architectures with alignment requirements, or different endianness. 3) Use macros to hide away the mask/offsets, or better yet, inlined functions.
Could we use _X86_ for one structure type and have the other too? Thanks, James