Re: [ros-dev] [ros-diffs] [gedmurphy] 52364: [BROWSEUI] - Set the prototypes to be long instead of LONG. This only worked in rbuild previously because WIDL incorrectly generates a LONG for long types. - define SHANDLE_PTR a...

[Ged Murphy]

Timo Kreuzer wrote:
>   Am 19.06.2011 15:47, schrieb Ged Murphy:
> >   Colin Finck wrote:
> >  If you're referring to fixing it by removing __ROS_LONG64__, then 
> >  that's not
> >  a proper fix either. 
>  I don't think __ROS_LONG64__ is a good workaround. It
> creates a lot of 
>  trouble. I had to disable it for amd64 completely since I would need to 
>  hack a lot of other code to make it work. 
I agree that it should be removed.
Also removing it will possibly allow the removal of this WIDL hack in
browseui.
However it won't fix the fact that WIDL outputs LONG instead of long 

>   > WIDL needs to be fixed to stop outputting
> 'LONG' types when 'long' is 
used
> >   in the
> > interface file. 
>  Its done on purpose by wine. so we will have to do our own
> "hack" on it. 
If gcc doesn't complain about the LONG / long mismatch (msvc will), and as
long as we always plan to use MIDL for the msvc build, then maybe it's an
incorrect 'feature' we can live with.