Re: [ros-dev] [ros-diffs] [spetreolle] 65378: [ADVAPI_WINETEST] Make peace^W tests, not war.☮ Wave a hello to sysreg so that it doesn't kill us. ROSTESTS-56

[Thomas Faber]

Hmm, my thought behind disabling this was more that this one test
doesn't justify increasing our whole test run time by 10%.


On 2014-11-11 11:12, spetreolle(a)svn.reactos.org wrote:
>   Author: spetreolle
>  Date: Tue Nov 11 16:12:14 2014
>  New Revision: 65378
>
>  URL: http://svn.reactos.org/svn/reactos?rev=65378&view=rev
>  Log:
>  [ADVAPI_WINETEST]
>  Make peace^W tests, not war.☮
>  Wave a hello to sysreg so that it doesn't kill us.
>  ROSTESTS-56
>
>  Modified:
>       trunk/rostests/winetests/advapi32/service.c
>
>  Modified: trunk/rostests/winetests/advapi32/service.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/advapi32/servic…
>  ==============================================================================
>  --- trunk/rostests/winetests/advapi32/service.c	[iso-8859-1] (original)
>  +++ trunk/rostests/winetests/advapi32/service.c	[iso-8859-1] Tue Nov 11 16:12:14 2014
>  @@ -2166,6 +2166,9 @@
>        DWORD le1, le2;
>        SERVICE_STATUS status;
>
>  +#ifdef __REACTOS__
>  +    fprintf(stdout, "ROSTESTS-56: Hello sysreg, I am awake\n");
>  +#endif
>        ret = StartServiceA(svc_handle, 0, NULL);
>        le1 = GetLastError();
>        ok(!ret, "%s: StartServiceA() should have failed\n", name);
>  @@ -2260,12 +2263,6 @@
>             * insanely long timeout: 120s. So skip the rest of the tests.
>             */
>            win_skip("Skip some service start/stop tests on NT4\n");
>  -        goto cleanup;
>  -    }
>  -
>  -    if (!winetest_interactive)
>  -    {
>  -        skip("ROSTESTS-56: Skipping service start timeout tests!\n");
>            goto cleanup;
>        }
>