Re: [ros-dev] [ros-diffs] [jgardou] 52365: [GDI32] - remove useless check.

[Timo Kreuzer]

Am 19.06.2011 15:11, schrieb jgardou(a)svn.reactos.org:
>   Author: jgardou
>  Date: Sun Jun 19 13:11:39 2011
>  New Revision: 52365
>  URL: http://svn.reactos.org/svn/reactos?rev=52365&view=rev
>  Log:
>  [GDI32]
>     - remove useless check.
>  +              _SEH2_TRY
>  +              {
>  +                      RtlCopyMemory( pvSafeBits, Bits, cjBmpScanSize);
>  +              }
>  +              _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
>  +              {
>  +                      Hit = TRUE;
>  +              }
>  +              _SEH2_END
>  +
>  +              if (Hit)
>  +              {
>  +                      // We don't die, we continue on with a allocated safe pointer
> to kernel
>  +                      // space.....
>  +                      DPRINT1("SetDIBitsToDevice fail to read BitMapInfo: %x or
> Bits: %x&  Size: %d\n",pConvertedInfo,Bits,cjBmpScanSize);
>  +              }
>  +              DPRINT("SetDIBitsToDevice Allocate Bits %d!!!\n",
> cjBmpScanSize);
>  +      }
>        if (!GdiGetHandleUserData(hdc, GDI_OBJECT_TYPE_DC, (PVOID)&pDc_Attr))
>        { 
This code looks retarded as well. Especially the comment about the
"safe" pointer...