Re: [ros-dev] [freeldr] Add PXE "filesystem" (Aleksey Bragin)

[Love Nystrom]

Hi Aleksey,

I'm sorry if my opinion came across as critique of the work as such.
It was definitely not intended that way.
I have great respect for all your efforts.

Just a point about unfortunate choice of AT&T syntax.
I would gladly volunteer to translate all old AT&T code to Intel.
After all, I do have 25 years of expertise in assembly coding.
It's just that I'm completely bogged down by R.L and have no time.
But if it can wait, just leave it be, and I'll do it later.
I'm sure Timo has enough to do with other issues already.

I abbreviated the pro's and con's to just two points,
of which the 2nd applies just to gcc's inline asm syntax.
Translating non-inline AT&T to Intel is fairly straight forward.

InvalidateHarshMode(TRUE);
No offence taken.

Best Regards
L.

On 2011-05-05 14.58, "Aleksey Bragin" <aleksey(a)reactos.org> wrote:
>   SetHarshMode(TRUE);
>
>  Your opinion would be interesting if it was motivated by your  
knowledge and
experience in writing assembly
>   in both AT&T and Intel syntax, so that you could
> provide us pros and  
cons of each approach by your judgement.
>  
>  Or, if you would be author of that code part in ReactOS.
>
>  Otherwise, I’m afraid, it’s just criticizing a very good work, didn’t  
even
noticing the great PXE milestone,
>    but nitpicking to a syntax. Don’t join complaints if
> you can’t fix  
it. (Timo’s point is valid because that’s him who actually >
converts 
this stuff!)
>  
>  SetHarshMode(FALSE);
>
>  WBR,
>  Aleksey.