Re: [ros-dev] [ros-diffs] [jimtabor] 57101: [NtUser] - Stop spurious window handle errors and code fixes.

[Thomas Faber]

Hey,

On 2012-08-18 23:40, [e-mail] wrote:
> URL:http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/caret.c...
>
> --- trunk/reactos/win32ss/user/ntuser/caret.c [iso-8859-1] (original)
> +++ trunk/reactos/win32ss/user/ntuser/caret.c [iso-8859-1] Sat Aug 18 21:40:49 2012
> @@ -42,14 +42,17 @@
>      if(!ThreadQueue || !ThreadQueue->CaretInfo)
>         return FALSE;
> pWnd = UserGetWindowObject(ThreadQueue->CaretInfo->hWnd);
>  co_IntHideCaret(ThreadQueue->CaretInfo);
>  ThreadQueue->CaretInfo->Bitmap = (HBITMAP)0;
>  ThreadQueue->CaretInfo->hWnd = (HWND)0;
>  ThreadQueue->CaretInfo->Size.cx = ThreadQueue->CaretInfo->Size.cy = 0;
>  ThreadQueue->CaretInfo->Showing = 0;
>  ThreadQueue->CaretInfo->Visible = 0;
> IntNotifyWinEvent(EVENT_OBJECT_DESTROY, pWnd, OBJID_CARET, CHILDID_SELF, 0);
> if (ThreadQueue->CaretInfo->hWnd)

this can never be true, as it was set to 0 above.
> {
>  pWnd = UserGetWindowObject(ThreadQueue->CaretInfo->hWnd);
>  IntNotifyWinEvent(EVENT_OBJECT_DESTROY, pWnd, OBJID_CARET, CHILDID_SELF, 0);
> }
>  return TRUE;
> }

Best,
Thomas