Subject: Re: [ros-diffs] [navaraf] 16149: Forgot this file in r16147.
From: Filip Navara <[email-masked]>
To: ReactOS Diffs List <[email-masked]>
Date: Mon, 20 Jun 2005 16:41:06 +0200

Royce Mitchell III wrote:

> [email-masked] wrote:
>
>> Forgot this file in r16147.
>>
>> Modified: trunk/reactos/ntoskrnl/include/internal/kbd.h
>>  
>>
>> ------------------------------------------------------------------------
>> *Modified: trunk/reactos/ntoskrnl/include/internal/kbd.h*
>>
>> --- trunk/reactos/ntoskrnl/include/internal/kbd.h    2005-06-20 
>> 13:43:26 UTC (rev 16148)
>> +++ trunk/reactos/ntoskrnl/include/internal/kbd.h    2005-06-20 
>> 13:54:52 UTC (rev 16149)
>> @@ -17,7 +17,7 @@
>>
>>   typedef struct _MODIFIERS {
>>     PVK_TO_BIT pVkToBit;
>>     WORD wMaxModBits;
>> -    BYTE ModNumber[1];
>> +    BYTE ModNumber[]; 
>>   } MODIFIERS, *PMODIFIERS;
>>
>> #define TYPEDEF_VK_TO_WCHARS(i) \
>>  
>>
> This change *fixes* a warning???
>
Together with the other changes ... yes. The strucuture is used like this:

ROSDATA MODIFIERS modifier_bits = {
  modifier_keys,
  3,
  { 0, 1, 2, 3 } /* Modifier bit order, NONE, SHIFT, CTRL, ALT */
};

and so the last member must be a variable-sized array.

- Filip