Message-ID: <42B6D582.5090907@reactos.com>
Date: Mon, 20 Jun 2005 16:41:06 +0200
From: Filip Navara <navaraf@reactos.com>
User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: ReactOS Diffs List <ros-diffs@reactos.com>
Subject: Re: [ros-diffs] [navaraf] 16149: Forgot this file in r16147.
References: <000001c5759f$a700e230$6b01a8c0@PENELOPE>
	<42B6CB67.2040904@ev1.net>
In-Reply-To: <42B6CB67.2040904@ev1.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Royce Mitchell III wrote:

> navaraf@svn.reactos.com wrote:
>
>> Forgot this file in r16147.
>>
>> Modified: trunk/reactos/ntoskrnl/include/internal/kbd.h
>>  
>>
>> ------------------------------------------------------------------------
>> *Modified: trunk/reactos/ntoskrnl/include/internal/kbd.h*
>>
>> --- trunk/reactos/ntoskrnl/include/internal/kbd.h    2005-06-20 
>> 13:43:26 UTC (rev 16148)
>> +++ trunk/reactos/ntoskrnl/include/internal/kbd.h    2005-06-20 
>> 13:54:52 UTC (rev 16149)
>> @@ -17,7 +17,7 @@
>>
>>   typedef struct _MODIFIERS {
>>     PVK_TO_BIT pVkToBit;
>>     WORD wMaxModBits;
>> -    BYTE ModNumber[1];
>> +    BYTE ModNumber[]; 
>>   } MODIFIERS, *PMODIFIERS;
>>
>> #define TYPEDEF_VK_TO_WCHARS(i) \
>>  
>>
> This change *fixes* a warning???
>
Together with the other changes ... yes. The strucuture is used like this:

ROSDATA MODIFIERS modifier_bits = {
  modifier_keys,
  3,
  { 0, 1, 2, 3 } /* Modifier bit order, NONE, SHIFT, CTRL, ALT */
};

and so the last member must be a variable-sized array.

- Filip