Hi Javier,

Actually I don’t think you’ve found where these code reviews are taking place. They are here:

and you can find there who’s currently reviewing them.

By what Alexander seems to say, the code changes seem to work quite well.

Hermès

De : Ros-dev [mailto:ros-dev-bounces@reactos.org] De la part de Javier Agustìn Fernàndez Arroyo
Envoyé : dimanche 16 avril 2017 10:59
À : ReactOS Development List
Objet : Re: [ros-dev] Vgal USB patches

please forgive me, as this may sound so rude...

Is this code reliable? is anyone reviewing it?

On Sat, Apr 15, 2017 at 2:09 PM, Alexander Rechitskiy <art1st-tm@yandex.ru> wrote:

Hello everyone!

Vgal sais that his code from СR-110 CR-111 is ready for trunk merging.

Vgal's changes were tested a lot by the Russian community. Huge regressions are impossible. We have enough time before release (1 month and two days). I can't imagine a better time for the merge.

We need the upcoming release to be great again!

06.04.2017, 08:14, "Peter Hater" <7element@mail.bg>:

Code review is open for everyone.
Go ahead at search for ((not so) obvious) bugs :)
CR-110/CR-111 maybe more.

BR,
Peter

On Apr 6, 2017, at 08:09, Javier Agustìn Fernàndez Arroyo <elhoir@gmail.com> wrote:

Wo is reviewing that Code?

El 06/04/2017 06:46, "Peter Hater" <7element@mail.bg> escribió:
No.
This means that we won't have (much) BSODs and weird crashes when (dis)connecting usb devices.
Booting from usb is (at least) blocked by CORE-10456.

BR,
Peter

> On Apr 6, 2017, at 04:01, Thomas Mueller <mueller6723@twc.com> wrote:
>
> from Robert Naumann:
>
>> Codereview is already ongoing. If everything goes well, USB will become
>> great again soon.
>
> Does this mean it will be possible to build ReactOS and install to a USB stick so as to be bootable?
>
> Tom
>
>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>

_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
,
_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

--
Best regards,

_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev