Re: [ros-dev] [ros-diffs] [fireball] 27185: - Set esp in the beginning to freeldr's stack, fixes a crash during a call to the kernel's entrypoint. - Comment out some annoying / unnecessary dprints (including messagebox about not resolved imports for pciide).

[Alex Ionescu]

So the new ReactOS is all about adding hacks to the kernel and hiding existing bugs
instead of finding solutions. Cool beans. Maybe you should also comment out other DPRINTs.
I mean, if a critical warning that a driver wasn't properly loaded because FreeLDR
doesn't process import tables and that thus the device won't work right is
annoying, maybe stuff like "File not found" should also be removed and return
success instead.

I can't wait 6 months from now when everyone wonders how come some driver doesn't
load in ReactOS. Are you and hto actually the same person?

-----Original Message-----
From: ros-diffs-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of
fireball(a)svn.reactos.org
Sent: Friday, June 15, 2007 3:27 AM
To: ros-diffs(a)reactos.org
Subject: [ros-diffs] [fireball] 27185: - Set esp in the beginning to freeldr's stack,
fixes a crash during a call to the kernel's entrypoint. - Comment out some annoying /
unnecessary dprints (including messagebox about not resolved imports for pciide).

Author: fireball
Date: Fri Jun 15 14:27:27 2007
New Revision: 27185

URL: http://svn.reactos.org/svn/reactos?rev=27185&view=rev
Log:
- Set esp in the beginning to freeldr's stack, fixes a crash during a call to the
kernel's entrypoint.
- Comment out some annoying / unnecessary dprints (including messagebox about not resolved
imports for pciide).

Modified:
    branches/olpc/boot/freeldr/freeldr/arch/i386/arch.S
    branches/olpc/boot/freeldr/freeldr/arch/i386/loader.c
    branches/olpc/boot/freeldr/freeldr/arch/i386/macholpc.c

Modified: branches/olpc/boot/freeldr/freeldr/arch/i386/arch.S
URL:
http://svn.reactos.org/svn/reactos/branches/olpc/boot/freeldr/freeldr/arch/…
==============================================================================
--- branches/olpc/boot/freeldr/freeldr/arch/i386/arch.S (original)
+++ branches/olpc/boot/freeldr/freeldr/arch/i386/arch.S Fri Jun 15 14:27:27 2007
@@ -395,7 +395,7 @@
 	//movw	%dx,%fs
 	//movw	%dx,%gs
 	//movw	%dx,%ss
-	//movl	$STACK32ADDR,%esp
+	movl	$STACK32ADDR,%esp
 
 	//movl	$mb_info,%ebx
 	/* See if the boot device was passed in */

Modified: branches/olpc/boot/freeldr/freeldr/arch/i386/loader.c
URL:
http://svn.reactos.org/svn/reactos/branches/olpc/boot/freeldr/freeldr/arch/…
==============================================================================
--- branches/olpc/boot/freeldr/freeldr/arch/i386/loader.c (original)
+++ branches/olpc/boot/freeldr/freeldr/arch/i386/loader.c Fri Jun 15 14:27:27 2007
@@ -487,7 +487,7 @@
         }
         else
         {
-            DbgPrint("Don't yet support loading new modules from
imports\n");
+            //DbgPrint("Don't yet support loading new modules from
imports\n");
             Status = STATUS_NOT_IMPLEMENTED;
         }
     }

Modified: branches/olpc/boot/freeldr/freeldr/arch/i386/macholpc.c
URL:
http://svn.reactos.org/svn/reactos/branches/olpc/boot/freeldr/freeldr/arch/…
==============================================================================
--- branches/olpc/boot/freeldr/freeldr/arch/i386/macholpc.c (original)
+++ branches/olpc/boot/freeldr/freeldr/arch/i386/macholpc.c Fri Jun 15 14:27:27 2007
@@ -253,7 +253,7 @@
 
 BOOLEAN OlpcDiskGetDriveGeometry( ULONG DriveNumber, PGEOMETRY DriveGeometry )
 {
-    ofwprintf("GetGeometry(%d)\n", DriveNumber);
+    //ofwprintf("GetGeometry(%d)\n", DriveNumber);
     DriveGeometry->BytesPerSector = 512;
     DriveGeometry->Heads = 16;
     DriveGeometry->Sectors = 63;
@@ -262,7 +262,7 @@
 
 ULONG OlpcDiskGetCacheableBlockCount( ULONG DriveNumber )
 {
-    ofwprintf("GetCacheableBlockCount\n");
+    //ofwprintf("GetCacheableBlockCount\n");
     return 1;
 }