Re: [ros-dev] [ros-diffs] [jgardou] 53551: - revert r53547, although setting explicitly something which is default isn't a "wrong change" per se.

[Alex Ionescu]

It is when it breaks the easyness to sync this code with it's original
source and do diffs, sorry for not being clear. I believe the whole driver
was carefully commented in the locations where it differs from the original
source, and this would've added extra burden.

Best regards,
Alex Ionescu

On Sat, Sep 3, 2011 at 5:44 PM, [e-mail] wrote:
> Author: jgardou
> Date: Sat Sep  3 16:44:49 2011
> New Revision: 53551
>
> URL: http://svn.reactos.org/svn/reactos?rev=53551&view=rev
> Log:
> revert r53547, although setting explicitly something which is default
>
> isn't a "wrong change" per se.
>
> Modified:
>    trunk/reactos/drivers/video/miniport/vga_new/vga.c
>
> Modified: trunk/reactos/drivers/video/miniport/vga_new/vga.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/miniport/vga_...
>
> ==============================================================================
> --- trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1]
> (original)
> +++ trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] Sat Sep
>  3 16:44:49 2011
> @@ -19,7 +19,6 @@
>  //
>
> VP_STATUS
> -NTAPI
>  VgaFindAdapter(
>     PVOID HwDeviceExtension,
>     PVOID HwContext,
> @@ -29,13 +28,11 @@
>     );
>
> BOOLEAN
> -NTAPI
>  VgaInitialize(
>     PVOID HwDeviceExtension
>     );
>
> BOOLEAN
> -NTAPI
>  VgaStartIO(
>     PVOID HwDeviceExtension,
>     PVIDEO_REQUEST_PACKET RequestPacket
> @@ -105,7 +102,6 @@
>     );
>
> VP_STATUS
> -NTAPI
>  GetDeviceDataCallback(
>    PVOID HwDeviceExtension,
>    PVOID Context,
> @@ -134,6 +130,7 @@
>  #pragma alloc_text(PAGE,VgaSetColorLookup)
>  #endif
>
> +
>
> //---------------------------------------------------------------------------
>  ULONG
>  // eVb: 1.3 [GCC] - Add NTAPI for GCC support
> @@ -306,10 +303,9 @@
>     return initializationStatus;
>
> } // end DriverEntry()
>
> +
>
> //---------------------------------------------------------------------------
>  VP_STATUS
> -NTAPI
>  VgaFindAdapter(
>     PVOID HwDeviceExtension,
>     PVOID HwContext,
> @@ -387,7 +383,7 @@
>     if ((ConfigInfo->AdapterInterfaceType == Internal) &&
>         (VideoPortGetDeviceData(HwDeviceExtension,
>                                 VpControllerData,
>                            GetDeviceDataCallback,
>                            &GetDeviceDataCallback,
>                           VgaAccessRange) != NO_ERROR))
> {
>       return ERROR_INVALID_PARAMETER;
>
> @@ -489,10 +485,9 @@
>
> } // VgaFindAdapter()
>
> +
>
> //---------------------------------------------------------------------------
>  BOOLEAN
> -NTAPI
>  VgaInitialize(
>     PVOID HwDeviceExtension
>     )
> @@ -532,10 +527,9 @@
>     return TRUE;
>
> } // VgaInitialize()
>
> +
>
> //---------------------------------------------------------------------------
>  BOOLEAN
> -NTAPI
>  VgaStartIO(
>     PVOID HwDeviceExtension,
>     PVIDEO_REQUEST_PACKET RequestPacket
> @@ -1446,9 +1440,8 @@
>     return ERROR_INVALID_PARAMETER;
>
> } // end VgaSetColorLookup()
>
> +
>  VP_STATUS
> -NTAPI
>  GetDeviceDataCallback(
>     PVOID HwDeviceExtension,
>     PVOID Context,