Re: [ros-dev] [ros-diffs] [greatlrd] 33807: add Test for EngDeleteSemaphore, it only test if it been create or not

[Alex Ionescu]

I'm getting *quite* annoyed with seeing these kinds of tests:

ret = SomeFunc();
ASSERT(ret == success);

How exactly is this a test anyway? It proves in NO way that the
function *worked*, only that it returned success. Furthermore, there
are *plenty* of cases where a function could legitimately fail -- it
is simply stupid to assume that a failure means a regression. What if
the system is out of memory?

On Sun, Jun 1, 2008 at 10:38 PM,  <greatlrd(a)svn.reactos.org> wrote:
>   Author: greatlrd
>  Date: Sun Jun  1 09:38:02 2008
>  New Revision: 33807
>
>  URL: http://svn.reactos.org/svn/reactos?rev=33807&view=rev
>  Log:
>  add Test for EngDeleteSemaphore, it only test if it been create or not
>
>  Added:
>     trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c   (with props)
>  Modified:
>     trunk/rostests/apitests/gdi32api/testlist.c
>
>  Modified: trunk/rostests/apitests/gdi32api/testlist.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32api/testlis…
>  ==============================================================================
>  --- trunk/rostests/apitests/gdi32api/testlist.c [iso-8859-1] (original)
>  +++ trunk/rostests/apitests/gdi32api/testlist.c [iso-8859-1] Sun Jun  1 09:38:02 2008
>  @@ -11,6 +11,7 @@
>   #include "tests/CreateFont.c"
>   #include "tests/CreatePen.c"
>   #include "tests/CreateRectRgn.c"
>  +#include "tests/EngCreateSemaphore.c"
>   #include "tests/ExtCreatePen.c"
>   #include "tests/GdiConvertBitmap.c"
>   #include "tests/GdiConvertBrush.c"
>  @@ -51,6 +52,7 @@
>         { L"CreateCompatibleDC", Test_CreateCompatibleDC },
>         { L"CreateFont", Test_CreateFont },
>         { L"CreatePen", Test_CreatePen },
>  +       { L"EngCreateSemaphore", Test_EngCreateSemaphore },
>         { L"CreateRectRgn", Test_CreateRectRgn },
>         { L"ExtCreatePen", Test_ExtCreatePen },
>         { L"GdiConvertBitmap", Test_GdiConvertBitmap },
>
>  Added: trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/gdi32api/tests/E…
>  ==============================================================================
>  --- trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c (added)
>  +++ trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c [iso-8859-1] Sun Jun  1
> 09:38:02 2008
>  @@ -1,0 +1,15 @@
>  +/* Simple test of EngAcquireSemaphore only check if we got a lock or not */
>  +INT
>  +Test_EngCreateSemaphore(PTESTINFO pti)
>  +{
>  +
>  +    HSEMAPHORE hsem;
>  +    hsem = EngCreateSemaphore();
>  +
>  +    RTEST ( hsem != NULL );
>  +
>  +    EngDeleteSemaphore(hsem);
>  +
>  +    return APISTATUS_NORMAL;
>  +}
>  +
>
>  Propchange: trunk/rostests/apitests/gdi32api/tests/EngCreateSemaphore.c
>  ------------------------------------------------------------------------------
>     svn:eol-style = native
>
>  


-- 
Best regards,
Alex Ionescu