We already submit fixes to Wine.
Since Wine is upstream, patches are sent to Wine first.
I didn't 'reject' your patch blindly. There is also a change into shlwapi and freetype, which is 3rd party.
Changes to 3rd party code give silent reverts or conflicts at update time, better be safe than sorry.
See [reactos] Revision 57747 and [#CORE-6495] unicode: some CLI Programs compiled and using unicode outputs characters incorrectly. - ReactOS JIRA for an example of these.


 
Kind regards,
Sylvain Petreolle


De : Love Nystrom <love.nystrom@gmail.com>
À : ReactOS Development List <ros-dev@reactos.org>
Envoyé le : Vendredi 14 novembre 2014 12h56
Objet : [ros-dev] ReactOS/Wine patches.

@Sylvain,

It occurred to me that since we have a lot of Wine code in ReactOS,
there will often be cases where ReactOS patches target Wine code.

Instead of just rejecting those patches, which is likely to make them
never see the light of day, the ReactOS programmers who maintain
our Wine code could act as liaisons, and review/post them to Wine.

I think that would make it more likely that Wine will commit those
patches in a timely fashion, since they are likely to know our liaisons,
and we would gain by a faster turnaround on fixes in Wine code.

What do You think?




Best Regards
// Love


_______________________________________________
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev