If we continue the clean rebuild method for RosBuild, the only way to reduce build time is removing stuff from the build. If we stuff everything in trunk and just switch it off in the config file it will lead to missing functionality in the iso's. So I'd rather suggest seperating stuff from trunk, moving it into rosapps or whatever and then rebuild only the tree where the last commit went to, while still putting the other stuff into the iso. We should also avoid compiling trunk on branch commits, a functionality I miss since a long time. But we would need to make the modules independ from trunk then. Wich would finally lead to seperate the import libraries from the modules. IMO in the long run a much greater seperation is needed. Having multiple independend trees, each being individually recompiled on a change. (See my earlier mail or sedwards' mail)
I also don't like the idea of removing everything that is in rosapps. There's a lot of stuff that shouldn't go to trunk, but still has it's right to exist somewhere in our sources.
I second the divide into 3 solution.
Timo
Ged schrieb:
I prefer this idea.
I'd like to see rosapps removed completely and have all non essential stuff in trunk built via an rbuild variable (turned off by default)
Ged.
-----Original Message----- From: ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org] On Behalf Of Thomas Bluemel Sent: 12 March 2009 14:17 To: ReactOS Development List Subject: Re: [ros-dev] rosapps
Instead of actually removing this stuff from trunk, can't we drive this by an environment variable with rbuild so that it skips building modules not neccessary?
Thomas Aleksey Bragin wrote:
So, are there any objections in separating thirdparty, additional, sometimes helpful stuff into addons module, and having all apps which exist in Windows, but aren't required for booting into rosapps?
Please, let's come to a solution, because having such a trash can which rosapps is now is unbearable.
WBR, Aleksey Bragin.
On Mar 9, 2009, at 2:50 AM, Ged wrote:
I would opt for deleting everything in rosapps.
I'm not really sure why it's important to start rearranging it as there's very little of use in there.
As per our project mandate we aren't interested in anything which isn't core.
Ged.
*From:* ros-dev-bounces@reactos.org [mailto:ros-dev-bounces@reactos.org] *On Behalf Of *Aleksey Bragin *Sent:* 08 March 2009 18:16 *To:* ReactOS Development List *Subject:* Re: [ros-dev] rosapps
I'll explain his idea.
The idea he would likes to propose is to separate the mess inside rosapps, and provide a clear division of what goes where:
- trunk/reactos contains ONLY stuff which is vital for the system to
work minimally. Including explorer, GUI, and things like that, but without calculator, solitaire, or anything like that.
- rosapps - components similar to those present in Windows, but not
vital for the boot process.
- addons - components, which are additional to the base set of apps
and drivers Windows ships with.
Comments are welcome on his idea.
My own comment is that the idea seems to recall what we originally been discussing a year or more ago, but stopped caring as more devs got more powerful PCs. There is no strict solution on what goes where now, actually that's why his idea started - he proposed to move winver and winhlp back to trunk, and I was arguing over it.
WBR,
Aleksey Bragin.
On Mar 8, 2009, at 7:02 PM, Zachary Gorden wrote:
Huh? The rosapps module isn't included by default in the build to begin with, so how does it decrease build time? Also, the applications in there are supposed to be providing equivalent functionality found in Windows. Downloader is an exception, but what else is?
On Sun, Mar 8, 2009 at 8:00 AM, Dmitry Chapyshev <lentind@yandex.ru mailto:lentind@yandex.ru> wrote:
Hi.
I suggest to divide rosapps on two parts:
- Components which are present in Windows (rosapps)
- 3rd party components (3rdapps)
In rosapps it is necessary to place all components without which the system can normally work (calc, hh, winhlp32, charmap, games and etc)
In 3rdapps components which are not present in Windows (downloader, imagesoft and etc) will take places
Such placing of components will allow to reduce compilation time as you can not compile not the modules necessary to you (rosapps and/or 3rdapps)
Please tell your opinion on my proposition.
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev