Yes EnterUserExclusive is used alot elsewhere in win32k and we dont really need to use it with timers, so its inefficient. I'm going to change this so that timers use thier own lock.
mike Date: Sun, 30 May 2010 23:48:11 +0100 From: gedmurphy@gmail.com To: ros-dev@reactos.org Subject: Re: [ros-dev] [ros-diffs] [mjmartin] 47393: [win32k] - The timer is created usingUserCreateObject. It may be a good idea to save the handle in the timer object so that it can be deleted later. - Dereference the object before attempting to delete it.
I've spoken to Mike about this, apparently the lock is held much higher in the call chain (EnterUserExclusive), which isn't obvious in the patch.