Re: [ros-dev] [ros-diffs] [hbelusca] 58902: [FREELDR] - Fix some function parameter types, so to avoid unuseful casts (from pointers to const strings to pointers to strings in particular). - The big thing: make FreeLdr load...

[Aleksey Bragin]

I'm fine with oneliner if statemens, like
if (!NT_SUCESS(Status)) return Status;

as they actual make sense.

However, in this case with a while example, it's far from being 
readable. Also, why use preincrement instead of a postincrement, when 
the resulting value is not used?

Regards,
Aleksey Bragin

On 01.05.2013 22:31, Timo Kreuzer wrote:
> I'm not a fan of single line conditional statements.
> I'd prefer if we had a style rule for that.
> Any thoughts on that?
>
> Am 01.05.2013 19:12, schrieb [e-mail]:
> > Author: hbelusca
> > Date: Wed May  1 17:12:56 2013
> > New Revision: 58902
> >   do
> >   {
> >    while (*LoadOptions == '/')
> >        ++LoadOptions;
> >    while (*LoadOptions == '/') ++LoadOptions;
> >     *NewLoadOptions++ = *LoadOptions;
> > } while (*LoadOptions++);