Re: [ros-dev] [ros-diffs] [jimtabor] 31204: Up the handle count to 0x10000, reset adjustment to support change. Add device capabilities to handle table.

[Alex Ionescu]

Yes, so 0-FFFF are *valid*.

The check disqualifies 0xFFFF. It should either be:

if (HandleIndex >= GDI_HANDLE_COUNT) (What Timo meant)

or

if (HandleIndex > GDI_HANDLE_COUNT - 1) (What you probably mean)

On 13-Dec-07, at 10:07 PM, James Tabor wrote:

>   Hi,
>  XXXX[10000] == 0 -> FFFF. The changes are correct.
>  Thanks,
>  James
>
>  On Dec 13, 2007 8:20 PM, Timo Kreuzer <timo.kreuzer(a)web.de> wrote:
> >   why waste the last handle?
> >
> > >   author: jimtabor
> > >  Date: Thu Dec 13 23:27:28 2007
> > >  New Revision: 31204
> > >  -     for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT; i++ )
> > >  +     for ( i = RESERVE_ENTRIES_COUNT; i < GDI_HANDLE_COUNT-1; i++
> > >  -   if (HandleIndex >= GDI_HANDLE_COUNT)
> > >  +   if (HandleIndex >= GDI_HANDLE_COUNT-1) 
> >  
> _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev 
Best regards,
Alex Ionescu