18 May
2011
18 May
'11
1:30 a.m.
Hi!
I did not mean you should copy the DDK code, I am sorry you misunderstood me (otherwise,
I'd have added "..so why are you rewriting it, idiot??").
Instead, I wanted to point out that as msports.inf/.h/.lib and pnpports are in the DDK:
1) The interfaces are known and documented, which
a) Should make your job easier in case you weren't aware
b) Means you need to maintain perfect compatibility even (perhaps) at the linker level,
as developers would try linking with the ReactOS msports instead
c) At the very least, we can share/duplicate the headers in a XDK-compatible way (Amine
is good with that)
d) Enums/defines, etc, can be re-used
2) There is more test code/documentation available for you to test with
3) A regression/compatibility test can be made by testing the MS implementation with
yours
I agree with you on your other points, hope this cleared things up.
--
Best regards,
Alex Ionescu
On 2011-05-17, at 6:04 PM, Eric Kohl wrote:
Hello Alex!
Thank you very much for letting us all know that the source code for msports is available
in the DDK!
BUT!
a) I know that for several years! And I guess other developer know that too. There is
absolutely no need to point us to the obvious!
b) I do not like Microsoft code in the ReactOS code base.
c) The DDK sample is incomplete. It uses the ComDB functions but does not implement them
for an obvious reason. Finding this reason is left to the reader as an exercise.
d) It is much easier to get a simple piece of code running and extend it bit by bit than
getting the whole DLL running at once. My latest commits to the setupapi dll are a result
of the work on msports and another class installer.
Now, take your DDK and play somehere else!
Regards,
Eric
The source code for msports is already available
in the DDK.
--
Best regards,
Alex Ionescu
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev