RE: [ros-dev] ntoskrnl/ex/i386/interlck_asm.S fails to compile due to EFLAG_SELECT

[Ge van Geldorp]

>   From: Alex Buell
>  
>  I thought that it was agreed that the minimum version of 
>  binutils would be at least 2.15.90.0.2? The fix for this 
>  requires a newer version?
>  
>  make[1]: Entering directory `/home/alex/src/OpSys/reactos'
>  [GAS]      ntoskrnl/ex/i386/interlck_asm.S
>  ntoskrnl/ex/i386/interlck_asm.S: Assembler messages:
>  ntoskrnl/ex/i386/interlck_asm.S:440: Error: Unrecognized token `|0x4000' 
Patch below will probably fix this:

Index: include/ndk/asm.h
===================================================================
--- include/ndk/asm.h   (revision 20477)
+++ include/ndk/asm.h   (working copy)
@@ -291,7 +291,7 @@
 #define EFLAGS_VIP                              0x100000
 #define EFLAG_SIGN                              0x8000
 #define EFLAG_ZERO                              0x4000
-#define EFLAG_SELECT                            (EFLAG_SIGN | EFLAG_ZERO)
+#define EFLAG_SELECT                            (EFLAG_SIGN + EFLAG_ZERO)

 //
 // CR0