Re: [ros-dev] Re: [ros-cvs] CVS Update: reactos

[Filip Navara]

Alex Ionescu wrote:

>   Filip Navara wrote:
>
> >   Alex Ionescu wrote:
> >
> > >   Hi,
> > >
> > >  Please reverse this change. ExInterlocked* functions are FASTCALL, 
> > >  as previously defined. 
> >
> >
> >  Some are, some aren't! If you were looking in the DDK headers you'll see
> >
> >     #define ExInterlockedXxx ExfInterlockedXxx
> >     ...
> >     ULONG DDKFASTAPI
> >     ExInterlockedXxx(...);
> >
> >  which is confusing, but trust me I got the prototypes right. 
>
>  If you were looking in the DDK headers you'll see:
>
>  NTKERNELAPI
>  ULONG
>  FASTCALL
>  ExInterlockedAddUlong (
>     IN PULONG Addend,
>     IN ULONG Increment,
>     IN PKSPIN_LOCK Lock
>     ); 
You missed the line
#define ExInterlockedAddUlong           ExfInterlockedAddUlong
in MS ntddk.h so the declaration you're showing expands to

NTKERNELAPI
ULONG
FASTCALL
ExfInterlockedAddUlong (
   IN PULONG Addend,
   IN ULONG Increment,
   IN PKSPIN_LOCK Lock
   );

really, which is correct.

Regards,
Filip