Re: [ros-dev] freeldr

[Alex Ionescu]

The only reason I argued for a v-table is because of the brokenness of
the old code duplication.
My original goal was to remove the code duplication/waste.
Timo wants to remove code duplication/waste as well.
Anyway, if you agree with removing useless code, that's great.
Best regards,
Alex Ionescu
On Mon, Jun 20, 2011 at 8:06 PM, Brian Palmer <brianp(a)sginet.com> wrote:
>   Please see the continuation of that *older* thread
> here:
>  http://www.reactos.org/pipermail/ros-general/2005-November/001987.html
>  And here, where you suggest using a vtable system instead of your original
>  idea:
>  http://www.reactos.org/pipermail/ros-general/2005-November/001988.html
>  And finally:
>  http://www.reactos.org/pipermail/ros-general/2005-November/001991.html
>  It's obvious from these threads that originally there was some confusion as
>  to what was going to be removed. After discussing it, we both came to
>  agreement. It's fine if you want to change your mind. Just please stop the
>  finger pointing at me.
>  I'm not opposed to removing the dead weight, especially in areas where
>  vtable like abstraction is not helpful. OTOH, there may still be some places
>  where a vtable like system is useful, and so the vtable stuff should be
>  removed carefully so that we don't lose any functionality in the process.
>  -----Original Message-----
>  From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
>  Behalf Of Alex Ionescu
>  Sent: Monday, June 20, 2011 11:54 AM
>  To: ReactOS Development List
>  Subject: Re: [ros-dev] freeldr
>  I googled for "Alex Ionescu "and "Brian Palmer".
>  First link:
>  http://www.reactos.org/pipermail/ros-dev/2005-November/006155.html.
>  Best regards,
>  Alex Ionescu
>  On Mon, Jun 20, 2011 at 4:44 AM, Brian Palmer <brianp(a)sginet.com> wrote:
> >   Again, please cite your sources Alex...
> >  I'm pretty sure you were the one who suggested this vtable system in the
> >  first place, for at least some parts of the FreeLoader code anyways, 
>  because
> >   I didn't write it. But it does have some
> > usefulness in places such as the 
>  UI
> >   code where, depending on the platform, it does
> > take a different code path,
> >  and multiple code paths are valid options to be compiled in and parsed at
> >  runtime depending on the .ini file.
> >  In any case, please stop adding useless comments like this unless you 
>  intend
> >   to bring up the original points of objection
> > along with it. A simple "I
> >  agree with the proposed change" would have sufficed here, and I'm tired of
> >  going the rounds with you over conversations that never took place.
> >  -----Original Message-----
> >  From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
> >  Behalf Of Alex Ionescu
> >  Sent: Sunday, June 19, 2011 7:27 AM
> >  To: ReactOS Development List
> >  Subject: Re: [ros-dev] freeldr
> >  I wrote this exact same request 3 years ago and Brian said no :)
> >  Best regards,
> >  Alex Ionescu
> >  On Sun, Jun 19, 2011 at 9:02 AM, Timo Kreuzer <timo.kreuzer(a)web.de> wrote:
> > >   Hi,
> > >  I'd like to change the Vtbl based architecture of freeldr into a normal
> > >  function call system.
> > >  Currently we have stuff like
> > >  #define MachHwDetect()                MachVtbl.HwDetect()
> > >     MachVtbl.HwDetect = PcHwDetect;
> > >  This is IHO simply useless, since these functions don't change. I suggest
> > >  simply renaming PcHwDetect to MachHwDetect and do that will all of those 
> >  and
> > >   get rid of the MachVtbl.
> > >  Any objections?
> > >  Regards,
> > >  Timo
> > >  _______________________________________________
> > >  Ros-dev mailing list
> > >  Ros-dev(a)reactos.org
> > >  http://www.reactos.org/mailman/listinfo/ros-dev
> > >  
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  _______________________________________________
> >  Ros-dev mailing list
> >  Ros-dev(a)reactos.org
> >  http://www.reactos.org/mailman/listinfo/ros-dev
> >  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>