If someone wants to implement
1. Alternate resource support
2. BasePostImportInit and related advanced stuff
3. Application compatibility hacks support
he should be at least that smart to see that support for those features is
totally non-existant, so there is nothing to warn about.
It’s similar to having this reminder in the early init stage:
DPRINT1(“ReactOS is in alpha stage, some features may be missing. You have been
warned!\n”);
WBR,
Aleksey Bragin.
Sent: Thursday, September 08, 2011 8:39 PM
Subject: Re: [ros-dev] [ros-diffs] [fireball] 53635: - Downgrade
someDPRINT1s to DPRINTs.
For
the stuff that was obviously designed to warn at least once, have you filled out
bug reports for all these missing features, or do you think that someone will
now remember all this missing code?
Best regards,
Alex Ionescu
On Thu, Sep 8, 2011 at 9:28 AM,
<fireball@svn.reactos.org>
wrote:
Author: fireball
Date: Thu Sep 8 08:28:41
2011
New Revision: 53635
URL: http://svn.reactos.org/svn/reactos?rev=53635&view=rev
Log:
-
Downgrade some DPRINT1s to DPRINTs.
Modified:
trunk/reactos/dll/ntdll/ldr/ldrapi.c
trunk/reactos/dll/ntdll/ldr/ldrinit.c
trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
Modified:
trunk/reactos/dll/ntdll/ldr/ldrapi.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrapi.c?rev=53635&r1=53634&r2=53635&view=diff
==============================================================================
---
trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] (original)
+++
trunk/reactos/dll/ntdll/ldr/ldrapi.c [iso-8859-1] Thu Sep 8 08:28:41
2011
@@ -1542,8 +1542,8 @@
NTAPI
LdrUnloadAlternateResourceModule(IN
PVOID BaseAddress)
{
- static BOOLEAN WarnedOnce =
FALSE;
- if (WarnedOnce == FALSE) { UNIMPLEMENTED;
WarnedOnce = TRUE; }
+ //static BOOLEAN WarnedOnce =
FALSE;
+ //if (WarnedOnce == FALSE) { UNIMPLEMENTED;
WarnedOnce = TRUE; }
return
FALSE;
}
Modified: trunk/reactos/dll/ntdll/ldr/ldrinit.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/ldrinit.c?rev=53635&r1=53634&r2=53635&view=diff
==============================================================================
---
trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] (original)
+++
trunk/reactos/dll/ntdll/ldr/ldrinit.c [iso-8859-1] Thu Sep 8 08:28:41
2011
@@ -728,7 +728,7 @@
/* Clear it */
//Kernel32ProcessInitPostImportfunction =
NULL;
-
UNIMPLEMENTED;
+
//UNIMPLEMENTED;
}
/* No root
entry? return */
@@ -1988,7 +1988,7 @@
if
(NtHeader->OptionalHeader.Subsystem ==
IMAGE_SUBSYSTEM_WINDOWS_GUI)
{
/* Load kernel32 and call
BasePostImportInit... */
-
DPRINT1("Unimplemented
codepath!\n");
+
DPRINT("Unimplemented codepath!\n");
}
/* Walk the IAT and load all the DLLs */
@@
-2095,7 +2095,7 @@
{
/* Check for Application
Compatibility Goo */
//LdrQueryApplicationCompatibilityGoo(hKey);
-
DPRINT1("Querying app compat hacks is
missing!\n");
+ DPRINT("Querying
app compat hacks is missing!\n");
}
/*
Modified:
trunk/reactos/ntoskrnl/mm/ARM3/procsup.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c?rev=53635&r1=53634&r2=53635&view=diff
==============================================================================
---
trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] (original)
+++
trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] Thu Sep 8 08:28:41
2011
@@ -590,7 +590,7
@@
ViewShare,
MEM_TOP_DOWN,
PAGE_READONLY);
- DPRINT1("NLS Tables at: %p\n",
TableBase);
+ DPRINT("NLS Tables at: %p\n",
TableBase);
if
(!NT_SUCCESS(Status))
{
/* Cleanup and exit */
@@
-602,7 +602,7 @@
// Allocate the
PEB
//
Status =
MiCreatePebOrTeb(Process, sizeof(PEB),
(PULONG_PTR)&Peb);
- DPRINT1("PEB at: %p\n",
Peb);
+ DPRINT("PEB at: %p\n",
Peb);
if (!NT_SUCCESS(Status))
{
/* Cleanup and exit
*/
Modified:
trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c?rev=53635&r1=53634&r2=53635&view=diff
==============================================================================
---
trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c [iso-8859-1]
(original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/process.c
[iso-8859-1] Thu Sep 8 08:28:41 2011
@@ -105,7 +105,7
@@
PROCESS_ALL_ACCESS,
&ObjectAttributes,
&ClientId);
-
DPRINT1("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
+
DPRINT("CSR Process: %p Handle: %p\n", pProcessData,
pProcessData->Process);
if (!NT_SUCCESS(Status))
{
ProcessData[hash] = pProcessData->next;
Modified:
trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c?rev=53635&r1=53634&r2=53635&view=diff
==============================================================================
---
trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c [iso-8859-1]
(original)
+++ trunk/reactos/subsystems/win32/csrss/csrsrv/api/wapi.c
[iso-8859-1] Thu Sep 8 08:28:41 2011
@@ -278,8 +278,8
@@
/* Check if we have a process
*/
if (CsrProcess)
{
- /* Map the sectio into this
process */
- DPRINT1("CSR Process
Handle: %p. CSR Process: %p\n", CsrProcess->Process,
CsrProcess);
+ /* Map the section
into this process */
+
DPRINT("CSR Process Handle: %p. CSR Process: %p\n", CsrProcess->Process,
CsrProcess);
Status =
NtMapViewOfSection(CsrSrvSharedSection,
CsrProcess->Process,
&CsrSrvSharedSectionBase,
@@ -520,7 +520,7
@@
Status =
CsrSrvAttachSharedSection(ProcessData,
ConnectInfo);
if
(NT_SUCCESS(Status))
{
-
DPRINT1("Connection
ok\n");
+
DPRINT("Connection
ok\n");
AllowConnection = TRUE;
}
else
_______________________________________________
Ros-dev mailing
list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev