Re: [ros-dev] [ros-diffs] [jgardou] 61545: [MESA] - Use PSEH to test and catch SSE exceptions #CORE-7727 Problem with software implementation is fixed with r61545. Investigating on vmware driver support.

[Zachary Gorden]

Uh, this is really, really old Mesa code that's been effectively imported
into ReactOS. See http://reactos.org/newsletter-95 the first section. Some
of Jerome's plans have changed since then, but the basic gist is still
there.

On Mon, Jan 6, 2014 at 7:39 PM, Timo Kreuzer [e-mail] wrote:
> Ok, but as another general rule, we should avoid hacking 3rd party code,
> unless definately required. I would prefer
> a) Providing a fix for the code that is acceptable for the original
> author(s) (which I think PSEH is most likely not)
> b) Fix our own code (and I'm still not sure whether the fix is actually
> required or just required because something on our side is broken)
> Of cause it would make sense to hack 3rd party code, when a fix for our
> own stuff is not expectable in the near future, but then it should be
> visibly marked as such, combined with a bug report.
> Otherwise we should think about a solution that we can merge upstream.
> Can you provide more information, why we need this change in this
> explicit case (other than "as a general rule") and whether it is
> reasonable to investigate a solution, that we can send upstream?
>
> Thanks,
> Timo
>
> Am 06.01.2014 23:36, schrieb Jerome Gardou:
> > As a general rule, we should not use SetUnhandledExceptionFilter,
>
> because it
> > has side effects.
>
> http://www.codeproject.com/Articles/154686/SetUnhandledExceptionFilter-and-t...
> > Le lundi 06 janvier 2014, 23:29:51 Timo Kreuzer a écrit :
> > > Is this a bug in the mesa code or are we lacking something here?
> > >
> > > Am 06.01.2014 19:39, schrieb [e-mail]:
> > > > Author: jgardou
> > > > Date: Mon Jan  6 18:39:42 2014
> > > > New Revision: 61545
> > > >
> > > > URL: http://svn.reactos.org/svn/reactos?rev=61545&view=rev
> > > > Log:
> > > > [MESA]
> > > > Use PSEH to test and catch SSE exceptions
> > > >
> > > > #CORE-7727 Problem with software implementation is fixed with r61545.
> > > > Investigating on vmware driver support.>
> > > > Modified:
> > > >     trunk/reactos/dll/opengl/mesa/x86/common_x86.c
> > > >
> > > > Modified: trunk/reactos/dll/opengl/mesa/x86/common_x86.c
> > > > URL:
>
> http://svn.reactos.org/svn/reactos/trunk/reactos/dll/opengl/mesa/x86/comm
> > > > on_x86.c?rev=61545&r1=61544&r2=61545&view=diff
>
> =========================================================================
> > > > ===== --- trunk/reactos/dll/opengl/mesa/x86/common_x86.c
>
> [iso-8859-1]
> > > > (original) +++
> > > > trunk/reactos/dll/opengl/mesa/x86/common_x86.c      [iso-8859-1] Mon
>
> Jan  6
> > > > 18:39:42 2014 @@ -51,6 +51,8 @@
> > > >
> > > > #include "main/imports.h"
> > > >  #include "common_x86_asm.h"
> > > >
> > > > +#include <pseh/pseh2.h>
> > >
> > > Ros-dev mailing list
> > > [e-mail]
> > > http://www.reactos.org/mailman/listinfo/ros-dev
> >
> > Ros-dev mailing list
> > [e-mail]
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev