Re: [ros-dev] [ros-diffs] [jgardou] 53547: [VGA_NEW] - fix some warnings

[Alex Ionescu]

These changes are wrong :(

Please use the correct compiler flag instead (-mrtd)

Best regards,
Alex Ionescu

On Sat, Sep 3, 2011 at 5:09 PM, [e-mail] wrote:
> Author: jgardou
> Date: Sat Sep  3 16:09:34 2011
> New Revision: 53547
>
> URL: http://svn.reactos.org/svn/reactos?rev=53547&view=rev
> Log:
> [VGA_NEW]
> fix some warnings
>
> Modified:
>    trunk/reactos/drivers/video/miniport/vga_new/vga.c
>
> Modified: trunk/reactos/drivers/video/miniport/vga_new/vga.c
> URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/video/miniport/vga_...
>
> ==============================================================================
> --- trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1]
> (original)
> +++ trunk/reactos/drivers/video/miniport/vga_new/vga.c [iso-8859-1] Sat Sep
>  3 16:09:34 2011
> @@ -19,6 +19,7 @@
>  //
>
> VP_STATUS
> +NTAPI
>  VgaFindAdapter(
>     PVOID HwDeviceExtension,
>     PVOID HwContext,
> @@ -28,11 +29,13 @@
>     );
>
> BOOLEAN
> +NTAPI
>  VgaInitialize(
>     PVOID HwDeviceExtension
>     );
>
> BOOLEAN
> +NTAPI
>  VgaStartIO(
>     PVOID HwDeviceExtension,
>     PVIDEO_REQUEST_PACKET RequestPacket
> @@ -102,6 +105,7 @@
>     );
>
> VP_STATUS
> +NTAPI
>  GetDeviceDataCallback(
>    PVOID HwDeviceExtension,
>    PVOID Context,
> @@ -130,7 +134,6 @@
>  #pragma alloc_text(PAGE,VgaSetColorLookup)
>  #endif
>
> -
>
> //---------------------------------------------------------------------------
>  ULONG
>  // eVb: 1.3 [GCC] - Add NTAPI for GCC support
> @@ -303,9 +306,10 @@
>     return initializationStatus;
>
> } // end DriverEntry()
> -
>
> //---------------------------------------------------------------------------
>  VP_STATUS
> +NTAPI
>  VgaFindAdapter(
>     PVOID HwDeviceExtension,
>     PVOID HwContext,
> @@ -383,7 +387,7 @@
>     if ((ConfigInfo->AdapterInterfaceType == Internal) &&
>         (VideoPortGetDeviceData(HwDeviceExtension,
>                                 VpControllerData,
>                            &GetDeviceDataCallback,
>                            GetDeviceDataCallback,
>                           VgaAccessRange) != NO_ERROR))
> {
>       return ERROR_INVALID_PARAMETER;
>
> @@ -485,9 +489,10 @@
>
> } // VgaFindAdapter()
> -
>
> //---------------------------------------------------------------------------
>  BOOLEAN
> +NTAPI
>  VgaInitialize(
>     PVOID HwDeviceExtension
>     )
> @@ -527,9 +532,10 @@
>     return TRUE;
>
> } // VgaInitialize()
> -
>
> //---------------------------------------------------------------------------
>  BOOLEAN
> +NTAPI
>  VgaStartIO(
>     PVOID HwDeviceExtension,
>     PVIDEO_REQUEST_PACKET RequestPacket
> @@ -1440,8 +1446,9 @@
>     return ERROR_INVALID_PARAMETER;
>
> } // end VgaSetColorLookup()
> -
>
> VP_STATUS
> +NTAPI
>  GetDeviceDataCallback(
>     PVOID HwDeviceExtension,
>     PVOID Context,