Re: [ros-dev] [ros-diffs] [cfinck] 28423: - Alwaysinclude"wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the firstinc

[Ged]

I agree with Steven on this, these changes should be avoided.
Many other changes along with this one also have the same problem. (e.g.
r28413)


-----Original Message-----
From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On
Behalf Of Steven Edwards
Sent: 19 August 2007 21:41
To: ReactOS Development List
Subject: Re: [ros-dev] [ros-diffs] [cfinck] 28423: -
Alwaysinclude"wine/unicode.h" before all other headers,when we need the
wchar_t type. unicode.h includes windef.h,which includes winnt.h,which has
the handling for the wchar_t type. As it's the firstinc

On 8/19/07, Colin Finck <mail(a)colinfinck.de> wrote:
>   These changes were made to properly compile ReactOS
> under a Mac OS X host.
>  They have nothing to do with MSVC or the Microsoft SDK headers. 
Sorry I was not clear about what I meant in my rant and sounded bitchy

>   Mac OS X defines its own wchar_t type in
> "ctype.h". But it uses 
>  _WCHAR_T for reporting that the type has been defined and not 
>  _WCHAR_T_DEFINED like Windows does.
>  This is why I needed to add a handling for _WCHAR_T in "winnt.h".
>  But if "ctype.h" is now included before "winnt.h", these changes
> don't 
>  have any effect. This is why I changed the header order.
>
>  Of course, there might be other "solutions" to this problem (like 
>  adding all possible definitions that wchar_t has been defined into the 
>  Makefile), but this is the simplest one.
>  And I see no reason not to do this for fixing this problem. 
It makes anyone doing a diff have more stuff to have to workaround.
There are constantly minor updates and fixes to the unicode tables in Wine
because Microsoft did not just generate them from the uncode.org spec but
added a bunch of stuff. Wine currently builds on OS X with the header order
as it stands and figures out someway around it. I guess its using a define
in the makefile for _WCHAR_T generated by configure or something. I have not
looked so don't quote me on that. I don't really care if you want to change
it to make it less of a hassle to build on OS X for ReactOS but its just
going to break again next time someone syncs the unicode lib so its better
if you can work around it in the makefile.

--
Steven Edwards

"There is one thing stronger than all the armies in the world, and that is
an idea whose time has come." - Victor Hugo
_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev


This message contains confidential information and is intended only for the individual
named. If you are not the named addressee you should not disseminate, distribute or copy
this e-mail. Please notify the sender immediately by e-mail if you have received this
e-mail by mistake and delete this e-mail from your system. E-mail transmission cannot be
guaranteed to be secure or error-free as information could be intercepted, corrupted,
lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does
not accept liability for any errors or omissions in the contents of this message, which
arise as a result of e-mail transmission. If verification is required please request a
hard-copy version. 

Amteus Secure Communications Ltd
57 Cardigan Lane,
Leeds, 
LS4 2LE
t: [phone]
f: [phone]

Registered in England No 4760795

http://www.amteus.com