Re: [ros-svn] [robertk] 16570: the release branch should be dbg=0

[Emanuele Aliberti]

robertk(a)svn.reactos.com wrote:

>  the release branch should be dbg=0
>
>
> Updated files:
> branches/ros-branch-0_2_7/reactos/config.template.xml
>
> _______________________________________________
> Ros-svn mailing list
> Ros-svn(a)reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-svn
>
>   
>  
Hi Robert,
shouldn't the config.template.xml be read only?

-- 
:Emanuele Aliberti

[Robert Köpferl]

I duno.

At least it makes sense to me to have dbg=0 in a release or ongoing ~ 
branch.
Do you want me to set it somehow r/o or was it a criticizing question?

Emanuele Aliberti wrote:
>   robertk(a)svn.reactos.com wrote:
>  
> >   the release branch should be dbg=0
> >
> >
> >  Updated files:
> >  branches/ros-branch-0_2_7/reactos/config.template.xml
> >
> >  _______________________________________________
> >  Ros-svn mailing list
> >  Ros-svn(a)reactos.com
> >  http://reactos.com:8080/mailman/listinfo/ros-svn
> >
> >   
> >  
>  Hi Robert,
>  shouldn't the config.template.xml be read only?
>

[Emanuele Aliberti]

Hi Robert,

>   I duno.
>
>  At least it makes sense to me to have dbg=0 in a release or ongoing ~ 
>  branch.
>  Do you want me to set it somehow r/o or was it a criticizing question? 
I simply asked if that is the intended usage of config.template.xml, 
because it is references in the very first XInclude statement in the 
master reactos.xml.

I may be wrong, but I read it this way: "if config.xml is not there, 
load config.template.xml", therefore assuming that, if I need to chenge 
the build configuration, I would

1. cp config.template.xml config.xml
2. edit config.xml

That seems a way to avoid accidentally committing local config changes 
in the SVN, because config.xml is *not* in the repository.

-- 
:Emanuele Aliberti

[Alex Ionescu]

Emanuele Aliberti wrote:

>   Hi Robert,
>
> >   I duno.
> >
> >  At least it makes sense to me to have dbg=0 in a release or ongoing ~ 
> >  branch.
> >  Do you want me to set it somehow r/o or was it a criticizing question? 
>
>  I simply asked if that is the intended usage of config.template.xml, 
>  because it is references in the very first XInclude statement in the 
>  master reactos.xml.
>
>  I may be wrong, but I read it this way: "if config.xml is not there, 
>  load config.template.xml", therefore assuming that, if I need to 
>  chenge the build configuration, I would
>
>  1. cp config.template.xml config.xml
>  2. edit config.xml
>
>  That seems a way to avoid accidentally committing local config changes 
>  in the SVN, because config.xml is *not* in the repository.
>  
Hi Emanuelle,

Yes, you are right, but this is not a local config change...it's a 
global SVN one, so config.template.xml was changed on purpose, that's 
the point.

Best regards,
Alex Ionescu

[Robert Köpferl]

Hmm, I've a gotcha, right now.
When I did the change, I just saw this sole, only file with the right 
contents. But I didn't notice the meaning of the word template.

So it was not quite what I intended, at this time.
What would you suggest to do ?  (to be build system conform)


Alex Ionescu wrote:
>   Emanuele Aliberti wrote:
>  
> >  
> >  I simply asked if that is the intended usage of config.template.xml, 
> >  because it is references in the very first XInclude statement in the 
> >  master reactos.xml.
> >
> >  I may be wrong, but I read it this way: "if config.xml is not there, 
> >  load config.template.xml", therefore assuming that, if I need to 
> >  chenge the build configuration, I would
> >
> >  1. cp config.template.xml config.xml
> >  2. edit config.xml
> >
> >  That seems a way to avoid accidentally committing local config changes 
> >  in the SVN, because config.xml is *not* in the repository.
> >  
>  Hi Emanuelle,
>  
>  Yes, you are right, but this is not a local config change...it's a 
>  global SVN one, so config.template.xml was changed on purpose, that's 
>  the point.
>  
>  Best regards,
>  Alex Ionescu
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.com
>  http://reactos.com:8080/mailman/listinfo/ros-dev
>

[Alex Ionescu]

Robert Köpferl wrote:

>   Hmm, I've a gotcha, right now.
>  When I did the change, I just saw this sole, only file with the right 
>  contents. But I didn't notice the meaning of the word template.
>
>  So it was not quite what I intended, at this time.
>  What would you suggest to do ?  (to be build system conform)
>  _____ 
I just wrote saying that your change was correct...

Best Regards,
Alex Ionescu

[Casper Hornstrup]

config.template.xml on the release branch should contain the default settings for the
source distribution. So if DBG = 0 is to be
the default for the source distribution then the change is correct. If not, then you
should copy config.template.xml to config.xml
and set DBG=0 in config.xml. Then build the binary distribution. The source distribution
should not contain a config.xml.

Casper

>   -----Original Message-----
>  From: ros-dev-bounces(a)reactos.com [mailto:[e-mail]] On Behalf Of
> Robert Köpferl
>  Sent: 17. juli 2005 23:04
>  To: ReactOS Development List
>  Subject: Re: [ros-dev] Re: [ros-svn] [robertk] 16570: the release branch shouldbe dbg=0
>  
>  Hmm, I've a gotcha, right now.
>  When I did the change, I just saw this sole, only file with the right
>  contents. But I didn't notice the meaning of the word template.
>  
>  So it was not quite what I intended, at this time.
>  What would you suggest to do ?  (to be build system conform)