Re: [ros-diffs] [arty] 13810: Some warning suppression. Read the<rant/>.

[d_layer]

Hi,

Actually this is a designed behavior of -Wconversion and not a bug.
http://gcc.gnu.org/ml/gcc/2002-12/msg01431.html

-- 
d_layer

arty(a)svn.reactos.com wrote:
>   + * <rant>
>  + * These fix the following warning in GCC:
>  + * warning: passing arg 1 of `ntohs' with different width due to
>  prototype
>  + *
>  + * Even if you declare an unsigned char or unsigned short variable and
>  pass
>  + * it to htons or ntohs, this warning will be generated.  I believe
>  this is
>  + * a gcc bug.  You can try to reproduce the bug like this:
>  + *
>  + * u_short foo(u_short bar) {
>  + *   return htons(bar);
>  + * }
>  + *
>  + * Using the reactos compiler settings this generates the error.
>  Unless I'm
>  + * missing something, the active prototypes for htons and ntohs are:
>  + *
>  + * u_short PASCAL htons(u_short);
>  + * u_short PASCAL ntohs(u_short);
>  + *
>  + * From winsock2.h.  Since the function above has exactly the same
>  signature
>  + * as htons except for the required PASCAL (__stdcall) decoration, gcc
>  is
>  + * erroneously detecting a narrowed value.
>  + * </rant>

[art yerkes]

On Fri, 4 Mar 2005 18:04:36 +0900
"d_layer" <dome(a)koganet.ne.jp> wrote:

>   Hi,
>  
>  Actually this is a designed behavior of -Wconversion and not a bug.
>  http://gcc.gnu.org/ml/gcc/2002-12/msg01431.html 
Thanks for pointing that out.  I lifted the flags from the original
makefile, which included those warnings enabled, including -Wconversion
but didn't think to check that one of these might be causing a spurious
warning.
-- 
Here's a simple experiment. Stand on a train track between two locomotives
which are pushing on you with equal force in opposite directions. You will
exhibit no net motion. None the less, you may soon begin to notice that
something important is happening.
-- Robert Stirniman