Re: [ros-svn] [hbirr] 14017: Added a keep-alive reference to each key object.

[James Tabor]

Hi!
hbirr(a)svn.reactos.com wrote:
>   Added a keep-alive reference to each key object.  
>  Lock the registry while accessing sub keys of a key object.  
>  Implemented a worker thread which removes all unused key objects.  
>  Fixed a bug which shows keys twice if a key is already opened.
>  
>  
>  
>  Updated files:
>  trunk/reactos/ntoskrnl/cm/cm.h
>  trunk/reactos/ntoskrnl/cm/ntfunc.c
>  trunk/reactos/ntoskrnl/cm/registry.c
>  trunk/reactos/ntoskrnl/cm/regobj.c
>   
ntoskrnl: [CC] cm/regobj.c
cm/regobj.c: In function `CmiObjectParse':
cm/regobj.c:244: error: parse error before '<<' token
cm/regobj.c:763: error: parse error at end of input
cm/regobj.c:23: warning: `CmiGetLinkTarget' declared `static' but never defined
make[1]: *** [cm/regobj.o] Error 1
make: *** [ntoskrnl] Error 2


8^),
James

[James Tabor]

James Tabor wrote:
>   Hi!
>  hbirr(a)svn.reactos.com wrote:
>  
> >   Added a keep-alive reference to each key object. 
> > Lock the registry 
> >  while accessing sub keys of a key object.  Implemented a worker thread 
> >  which removes all unused key objects.  Fixed a bug which shows keys 
> >  twice if a key is already opened.
> >
> >
> >
> >  Updated files:
> >  trunk/reactos/ntoskrnl/cm/cm.h
> >  trunk/reactos/ntoskrnl/cm/ntfunc.c
> >  trunk/reactos/ntoskrnl/cm/registry.c
> >  trunk/reactos/ntoskrnl/cm/regobj.c
> >  
>  
>  ntoskrnl: [CC] cm/regobj.c
>  cm/regobj.c: In function `CmiObjectParse':
>  cm/regobj.c:244: error: parse error before '<<' token
>  cm/regobj.c:763: error: parse error at end of input
>  cm/regobj.c:23: warning: `CmiGetLinkTarget' declared `static' but never 
>  defined
>  make[1]: *** [cm/regobj.o] Error 1
>  make: *** [ntoskrnl] Error 2
>  
>  
>  8^),
>  James 
I guess it depends on the compiler, 3.4.2 does this,

cm/regobj.c: In function `CmiObjectParse':
cm/regobj.c:244: error: syntax error before '<<' token
make[1]: *** [cm/regobj.o] Error 1
make: *** [ntoskrnl] Error 2

3.3.1 was the org post,
James

[Hartmut Birr]

James Tabor schrieb:

>  
>  ntoskrnl: [CC] cm/regobj.c
>  cm/regobj.c: In function `CmiObjectParse':
>  cm/regobj.c:244: error: parse error before '<<' token 
There is no '<<' token on line 244.

>   cm/regobj.c:763: error: parse error at end of input
The file has only 755 lines. You should clean your source.

>   cm/regobj.c:23: warning: `CmiGetLinkTarget'
> declared `static' but
>  never defined
>  make[1]: *** [cm/regobj.o] Error 1
>  make: *** [ntoskrnl] Error 2
>  
- Hartmut

[James Tabor]

OMG!

Hartmut Birr wrote:

>   You should clean your source. 
DOH!

Thanks Hartmut,
James