Re: [ros-svn] [greatlrd] 17380: change CMDLINE_LENGTH to 8192 to keep rbuild happy until dymatic alloc are in place

[James Tabor]

greatlrd(a)svn.reactos.com wrote:
>   change CMDLINE_LENGTH to 8192 to keep rbuild happy
> until dymatic alloc are in place
>  Updated files:
>  trunk/reactos/subsys/system/cmd/cmd.h
>   
Hi!
My problem with building is fix with this patch. I would make sure this setting
is the, no other, only minimum setting. Due to speed of allocating memory every
time cmd is running.
Thanks,
James

[Brandon Turner]

For a temp fix that will be merged to 0.2.7 i think this will work.  But
in the long haul we need to go with hartmuts idea of creating a dynamic
allocation system for cmd.
Brandon
James Tabor wrote:
>   greatlrd(a)svn.reactos.com wrote:
> >   change CMDLINE_LENGTH to 8192 to keep rbuild
> > happy until dymatic
> >  alloc are in place
> >  Updated files:
> >  trunk/reactos/subsys/system/cmd/cmd.h
> >  
>  Hi!
>  My problem with building is fix with this patch. I would make sure
>  this setting
>  is the, no other, only minimum setting. Due to speed of allocating
>  memory every
>  time cmd is running.
>  Thanks,
>  James
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.com
>  http://reactos.com:8080/mailman/listinfo/ros-dev
>

[James Tabor]

Yes, but a min of 8k.
Brandon Turner wrote:
>   For a temp fix that will be merged to 0.2.7 i think
> this will work.  But
>  in the long haul we need to go with hartmuts idea of creating a dynamic
>  allocation system for cmd.
>  Brandon
>  James Tabor wrote:
> > greatlrd(a)svn.reactos.com wrote:
> >
> >> change CMDLINE_LENGTH to 8192 to keep rbuild happy until dymatic
> >> alloc are in place
> >>
> >>
> >> Updated files:
> >> trunk/reactos/subsys/system/cmd/cmd.h
> >>
> > Hi!
> > My problem with building is fix with this patch. I would make sure
> > this setting
> > is the, no other, only minimum setting. Due to speed of allocating
> > memory every
> > time cmd is running.
> >
> > Thanks,
> > James

The minium for rbuild is betwin 500-600, I maby over do the alloc value. But it
will ensure most program will work fine. if you pipe in 8k long text file. yes
it exists stupied program that send in 8k direcly into cmd command line. But it
is a shurt term solvtions until one of us got the time to write the dymtaic
alloc, I do not know when I got time for it,  or some else got the time.
Quoting James Tabor <jimtabor(a)adsl-64-217-116-74.dsl.hstntx.swbell.net>et>:
>   Yes, but a min of 8k.
>  Brandon Turner wrote:
> >   For a temp fix that will be merged to 0.2.7 i
> > think this will work.  But
> >  in the long haul we need to go with hartmuts idea of creating a dynamic
> >  allocation system for cmd.
> >  Brandon
> >  James Tabor wrote:
> > > greatlrd(a)svn.reactos.com wrote:
> > >
> > >> change CMDLINE_LENGTH to 8192 to keep rbuild happy until dymatic
> > >> alloc are in place
> > >>
> > >>
> > >> Updated files:
> > >> trunk/reactos/subsys/system/cmd/cmd.h
> > >>
> > > Hi!
> > > My problem with building is fix with this patch. I would make sure
> > > this setting
> > > is the, no other, only minimum setting. Due to speed of allocating
> > > memory every
> > > time cmd is running.
> > >
> > > Thanks,
> > > James 
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.com
>  http://reactos.com:8080/mailman/listinfo/ros-dev
>

[Sylvain Petreolle]

But some programs are smaller than that !! 8-/
--- magnus(a)itkonsult-olsen.com a écrit :
>   The minium for rbuild is betwin 500-600, I maby over
> do the alloc value. But it
>  will ensure most program will work fine. if you pipe in 8k long text file. yes
>  it exists stupied program that send in 8k direcly into cmd command line. But it
>  is a shurt term solvtions until one of us got the time to write the dymtaic
>  alloc, I do not know when I got time for it,  or some else got the time.
>   
Kind regards,
Usurp (aka Sylvain Petreolle)
humans are like computers,
yesterday the BIOS was all
- today its just a word