Build Error

[James Tabor]

HI,

This started last night, config has this DBG := 0, when set (1), everything
compiles fine.

halmp: [CC] mpsirql.c
{standard input}: Assembler messages:
{standard input}:2378: Error: bad register name `%sil'
make[1]: *** [mpsirql.o] Error 1

FYI,
James

[Hartmut Birr]

James Tabor wrote:

>   HI,
>
>  This started last night, config has this DBG := 0, when set (1),
>  everything
>  compiles fine.
>
>  halmp: [CC] mpsirql.c
>  {standard input}: Assembler messages:
>  {standard input}:2378: Error: bad register name `%sil'
>  make[1]: *** [mpsirql.o] Error 1
>
>  FYI,
>  James 
Hi,

can you please try:

M:\Sandbox\ros_work\reactos>svn diff hal\halx86\include\hal.h
Index: hal/halx86/include/hal.h
===================================================================
--- hal/halx86/include/hal.h    (Revision 15545)
+++ hal/halx86/include/hal.h    (Arbeitskopie)
@@ -419,7 +419,7 @@
 static inline BYTE Ki386ReadFsByte(ULONG offset)
 {
    BYTE b;
-   __asm__ __volatile__("movb %%fs:(%1),%0":"=r" (b):"r"
(offset));
+   __asm__ __volatile__("movb %%fs:(%1),%0":"=g" (b):"0"
(offset));
    return b;
 }

Do you have specify 'OARCH := athlon-xp' or something else?

- Hartmut

[James Tabor]

Hi!
Hartmut Birr wrote:
>   Hi,
>  
>  can you please try:
>  
>  M:\Sandbox\ros_work\reactos>svn diff hal\halx86\include\hal.h
>  Index: hal/halx86/include/hal.h
>  ===================================================================
>  --- hal/halx86/include/hal.h    (Revision 15545)
>  +++ hal/halx86/include/hal.h    (Arbeitskopie)
>  @@ -419,7 +419,7 @@
>   static inline BYTE Ki386ReadFsByte(ULONG offset)
>   {
>      BYTE b;
>  -   __asm__ __volatile__("movb %%fs:(%1),%0":"=r" (b):"r"
> (offset));
>  +   __asm__ __volatile__("movb %%fs:(%1),%0":"=g" (b):"0"
> (offset));
>      return b;
>   }
>  
>  Do you have specify 'OARCH := athlon-xp' or something else?
>  
>  - Hartmut 
Sorry Hartmut,

OARCH:= tested athlon-xp and i486 with patch and still getting this

halmp: [CC] mpsirql.c
{standard input}: Assembler messages:
{standard input}:2377: Error: bad register name `%sil'
make[1]: *** [mpsirql.o] Error 1
make: *** [halx86/mp] Error 2

Thanks,
James

[Hartmut Birr]

James Tabor wrote:

>   Hi!
>  Hartmut Birr wrote:
>
> >   Hi,
> >
> >  can you please try:
> >
> >  M:\Sandbox\ros_work\reactos>svn diff hal\halx86\include\hal.h
> >  Index: hal/halx86/include/hal.h
> >  ===================================================================
> >  --- hal/halx86/include/hal.h    (Revision 15545)
> >  +++ hal/halx86/include/hal.h    (Arbeitskopie)
> >  @@ -419,7 +419,7 @@
> >   static inline BYTE Ki386ReadFsByte(ULONG offset)
> >   {
> >      BYTE b;
> >  -   __asm__ __volatile__("movb %%fs:(%1),%0":"=r" (b):"r"
> > (offset));
> >  +   __asm__ __volatile__("movb %%fs:(%1),%0":"=g" (b):"0"
> > (offset));
> >      return b;
> >   }
> >
> >  Do you have specify 'OARCH := athlon-xp' or something else?
> >
> >  - Hartmut 
>
>  Sorry Hartmut,
>
>  OARCH:= tested athlon-xp and i486 with patch and still getting this
>
>  halmp: [CC] mpsirql.c
>  {standard input}: Assembler messages:
>  {standard input}:2377: Error: bad register name `%sil'
>  make[1]: *** [mpsirql.o] Error 1
>  make: *** [halx86/mp] Error 2
>  
I get this only for an optimized build. Please try:

M:\Sandbox\ros_work\reactos>svn diff hal\halx86\include\hal.h
Index: hal/halx86/include/hal.h
===================================================================
--- hal/halx86/include/hal.h    (Revision 15545)
+++ hal/halx86/include/hal.h    (Arbeitskopie)
@@ -419,7 +419,7 @@
 static inline BYTE Ki386ReadFsByte(ULONG offset)
 {
    BYTE b;
-   __asm__ __volatile__("movb %%fs:(%1),%0":"=r" (b):"r"
(offset));
+   __asm__ __volatile__("movb %%fs:(%1),%0":"=A" (b):"0"
(offset));
    return b;
 }

- Hartmut

[James Tabor]

Hi,
Hartmut Birr wrote:
>   
>  I get this only for an optimized build. Please try:
>  
>  M:\Sandbox\ros_work\reactos>svn diff hal\halx86\include\hal.h
>  Index: hal/halx86/include/hal.h
>  ===================================================================
>  --- hal/halx86/include/hal.h    (Revision 15545)
>  +++ hal/halx86/include/hal.h    (Arbeitskopie)
>  @@ -419,7 +419,7 @@
>   static inline BYTE Ki386ReadFsByte(ULONG offset)
>   {
>      BYTE b;
>  -   __asm__ __volatile__("movb %%fs:(%1),%0":"=r" (b):"r"
> (offset));
>  +   __asm__ __volatile__("movb %%fs:(%1),%0":"=A" (b):"0"
> (offset));
>      return b;
>   }
>  
>  - Hartmut
>   
It broke this,

halup: [CC] ../generic/adapter.c
In file included from ../generic/adapter.c:20:
../include/hal.h: In function `Ki386ReadFsByte':
../include/hal.h:423: error: syntax error before "return"
../include/hal.h:424: warning: no return statement in function returning non-void
make[1]: *** [adapter.o] Error 1
make: *** [halx86/up] Error 2

Thanks,
James

[Hartmut Birr]

James Tabor wrote:

>   Hi,
>  Hartmut Birr wrote:
>
> >  
> >  I get this only for an optimized build. Please try:
> >
> >  M:\Sandbox\ros_work\reactos>svn diff hal\halx86\include\hal.h
> >  Index: hal/halx86/include/hal.h
> >  ===================================================================
> >  --- hal/halx86/include/hal.h    (Revision 15545)
> >  +++ hal/halx86/include/hal.h    (Arbeitskopie)
> >  @@ -419,7 +419,7 @@
> >   static inline BYTE Ki386ReadFsByte(ULONG offset)
> >   {
> >      BYTE b;
> >  -   __asm__ __volatile__("movb %%fs:(%1),%0":"=r" (b):"r"
> > (offset));
> >  +   __asm__ __volatile__("movb %%fs:(%1),%0":"=A" (b):"0"
> > (offset));
> >      return b;
> >   }
> >
> >  - Hartmut
> >  
>  It broke this,
>
>  halup: [CC] ../generic/adapter.c
>  In file included from ../generic/adapter.c:20:
>  ../include/hal.h: In function `Ki386ReadFsByte':
>  ../include/hal.h:423: error: syntax error before "return"
>  ../include/hal.h:424: warning: no return statement in function
>  returning non-void
>  make[1]: *** [adapter.o] Error 1
>  make: *** [halx86/up] Error 2
>
>  Thanks,
>  James 

Are you sure that is a semicolon at the end of line 422 in hal.h?

- Hartmut

[James Tabor]

Hartmut Birr wrote:
>   
>  
>  
>  Are you sure that is a semicolon at the end of line 422 in hal.h?
>  
>  - Hartmut 
DOH!  8^@

Yeah, it was missing!
Thanks,
James


Move on, there is nothing to see here~

it's compiling fine now.

[Hyperion]

James Tabor wrote:

>   halmp: [CC] mpsirql.c
>  {standard input}: Assembler messages:
>  {standard input}:2378: Error: bad register name `%sil'
>  make[1]: *** [mpsirql.o] Error 1  

fixed, but I cannot login to SVN to commit it ;-( (Casper, please, reset
my password). Here's the patch:

Index: halx86/include/hal.h
===================================================================
--- halx86/include/hal.h        (revision 15547)
+++ halx86/include/hal.h        (working copy)
@@ -419,7 +419,7 @@
static inline BYTE Ki386ReadFsByte(ULONG offset)
{
    BYTE b;
-   __asm__ __volatile__("movb %%fs:(%1),%0":"=r" (b):"r"
(offset));
+   __asm__ __volatile__("movb %%fs:(%1),%0":"=q" (b):"r"
(offset));
    return b;
}

and here's the bug (where I also found the workaround):

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10153

[Hyperion]

"KJK:"@mail.olografix.org:Hyperion wrote:

[...]

and why does stupid Thunderbird make such a mess of my nickname?

[Robert Köpferl]

Hehe, that's part of RFC822.

But seems not being respected in all parts of Thunderbird. See next 
line. Dine.mine.nu is my imap:

"KJK:"@[e-mail]:Hyperion wrote:
>   "KJK:"@mail.olografix.org:Hyperion wrote:
>  
>  [...]
>  
>  and why does stupid Thunderbird make such a mess of my nickname?
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.com
>  http://reactos.com:8080/mailman/listinfo/ros-dev
>

[Hyperion]

Robert Köpferl ha scritto:

>   Hehe, that's part of RFC822. 
what? no way, it's the only client that horribly destroys my nickname