RE: [ros-svn] [ion] 17650: - Fix kernel32 and ntoskrnl build issues.

[Ge van Geldorp]

>   From: ion(a)svn.reactos.com
>  
>  - Fix kernel32 and ntoskrnl build issues.
>  - Define public version of DEVOBJ_EXTENSION in DDK. 
Ok, I have to wonder, did you bother to do ANY testing on your
DEVOBJ_EXTENSION/EXTENDED_DEVOBJ_EXTENSION changes at all? Like, uhm, just
trying to boot? 'cause it seems very unlikely to me that you were able to
successfully boot. IoCreateDevice allocates only enough room for
DEVOBJ_EXTENSION, but the allocated pointer is cast to
PEXTENDED_DEVOBJ_EXTENSION (a much larger struct) all over the place, so
we're reading/writing outside allocated memory in a zillion places.

Gé van Geldorp.

[Alex Ionescu]

Ge van Geldorp wrote:

>  Ok, I have to wonder, did you bother to do ANY testing
> on your
> DEVOBJ_EXTENSION/EXTENDED_DEVOBJ_EXTENSION changes at all? 
>  
Yes...

>  Like, uhm, just
> trying to boot? 
>  
Yes

>  'cause it seems very unlikely to me that you were
> able to
> successfully boot. 
>  
I was, but since I hadn't worked on ReactOS in about two weeks I forgot 
to properly install the new files, and I was still running the old source.

>  IoCreateDevice allocates only enough room for
> DEVOBJ_EXTENSION, but the allocated pointer is cast to
> PEXTENDED_DEVOBJ_EXTENSION (a much larger struct) all over the place, so
> we're reading/writing outside allocated memory in a zillion places.
>   
>  
Yes, I just noticed that now, thanks for fixing it...

>  Gé van Geldorp.
>
>   
>  
Mistakes happen... do we really have to lash out on each others 
everytime? I'm starting to understand why so many people are getting 
tired of working on the project. People take time to work on complex, or 
simply long and ugly things, and instead of a single ounce of respect or 
thanks, they get yelled at for accidentally breaking something. It took 
me four hours to properly ensure everything built properly... do you 
really think I didn't bother to test?

Best regards,
Alex Ionescu

[Ge van Geldorp]

>   From: Alex Ionescu
>  
>  I was, but since I hadn't worked on ReactOS in about two 
>  weeks I forgot to properly install the new files, and I was 
>  still running the old source. 
Semantics, but I'd say the result was that you didn't test.

>   Mistakes happen... do we really have to lash out on
> each 
>  others everytime? I'm starting to understand why so many 
>  people are getting tired of working on the project. People 
>  take time to work on complex, or simply long and ugly things, 
>  and instead of a single ounce of respect or thanks, they get 
>  yelled at for accidentally breaking something. 
I fully understand that the only people who don't make mistakes are the
people who don't produce anything. I've been known to break things myself.
So when I (well, not just me, everyone) wasn't able to boot after applying
r17417 I didn't yell. But when a dev makes this same mistake twice in 3
weeks time, I do think a yell is in order.

Gé van Geldorp.