Missing header in rpcss

[Olaf Siejka]

It was spotted by MSVC build:
P:\Trunk_slave\MSVC-trunk\build\base\services\rpcss\irotp.c(28) : fatal
error C1083: Cannot open include file: 'irot_s.h': No such file or directory
LINK : fatal error LNK1104: cannot open file
'CMakeFiles/rpcss.dir/irotp.c.obj'
In base\services\rpcss\irotp.c:28 we see: #include "irot_s.h"
This file is not present in ReactOS trunk. In WINE's RPCSS
http://source.winehq.org/git/wine.git/blob/HEAD:/programs/rpcss/irotp.c :28
we have: #include "irot.h" which is also missing, and listed in .gitignore:
http://source.winehq.org/git/wine.git/blob?f=.gitignore
260 programs/rpcss/irot.h
261 programs/rpcss/irot_s.c
I think we can safely clean it up, perhaps adding proper line to ros-diff,
but i would like to ask you guys for confirmation.
Regards

[Ged Murphy]

It'll be autogenerated from the idl.
On 22 May 2011 13:02, Olaf Siejka <caemyr(a)gmail.com> wrote:
>   It was spotted by MSVC build:
>  P:\Trunk_slave\MSVC-trunk\build\base\services\rpcss\irotp.c(28) : fatal
>  error C1083: Cannot open include file: 'irot_s.h': No such file or directory
>  LINK : fatal error LNK1104: cannot open file
>  'CMakeFiles/rpcss.dir/irotp.c.obj'
>  In base\services\rpcss\irotp.c:28 we see: #include "irot_s.h"
>  This file is not present in ReactOS trunk. In WINE's RPCSS
>   http://source.winehq.org/git/wine.git/blob/HEAD:/programs/rpcss/irotp.c :28
>  we have: #include "irot.h" which is also missing, and listed in .gitignore:
>  http://source.winehq.org/git/wine.git/blob?f=.gitignore
>  260 programs/rpcss/irot.h
>  261 programs/rpcss/irot_s.c
>  I think we can safely clean it up, perhaps adding proper line to ros-diff,
>  but i would like to ask you guys for confirmation.
>  Regards
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[Olaf Siejka]

Can i safely remove this line then:
28    #include "irot_s.h"
2011/5/22 Ged Murphy <gedmurphy(a)gmail.com>
>   It'll be autogenerated from the idl.
>  On 22 May 2011 13:02, Olaf Siejka <caemyr(a)gmail.com> wrote:
> >   It was spotted by MSVC build:
> >  P:\Trunk_slave\MSVC-trunk\build\base\services\rpcss\irotp.c(28) : fatal
> >  error C1083: Cannot open include file: 'irot_s.h': No such file or 
> directory
> >   LINK : fatal error LNK1104: cannot open file
> >  'CMakeFiles/rpcss.dir/irotp.c.obj'
> >  In base\services\rpcss\irotp.c:28 we see: #include "irot_s.h"
> >  This file is not present in ReactOS trunk. In WINE's RPCSS
> >   http://source.winehq.org/git/wine.git/blob/HEAD:/programs/rpcss/irotp.c:28
> >  we have: #include "irot.h" which is also missing, and listed in 
> .gitignore:
> > http://source.winehq.org/git/wine.git/blob?f=.gitignore
> >  260 programs/rpcss/irot.h
> >  261 programs/rpcss/irot_s.c
> >  I think we can safely clean it up, perhaps adding proper line to 
>  ros-diff,
> >   but i would like to ask you guys for
> > confirmation.
> >  Regards 
>

[Olaf Siejka]

Ok, Aleksiej explained that one to me. Looks like MSVC build issue then.
2011/5/22 Olaf Siejka <caemyr(a)gmail.com>
>   Can i safely remove this line then:
>  28    #include "irot_s.h"
>  2011/5/22 Ged Murphy <gedmurphy(a)gmail.com>
> >   It'll be autogenerated from the idl.
> >  On 22 May 2011 13:02, Olaf Siejka <caemyr(a)gmail.com> wrote:
> > >   It was spotted by MSVC build:
> > >  P:\Trunk_slave\MSVC-trunk\build\base\services\rpcss\irotp.c(28) : fatal
> > >  error C1083: Cannot open include file: 'irot_s.h': No such file or 
> > directory
> > >   LINK : fatal error LNK1104: cannot open file
> > >  'CMakeFiles/rpcss.dir/irotp.c.obj'
> > >  In base\services\rpcss\irotp.c:28 we see: #include "irot_s.h"
> > >  This file is not present in ReactOS trunk. In WINE's RPCSS
> > >  
> >  http://source.winehq.org/git/wine.git/blob/HEAD:/programs/rpcss/irotp.c:28
> > >   we have: #include "irot.h" which is
> > > also missing, and listed in 
> >  .gitignore:
> > > http://source.winehq.org/git/wine.git/blob?f=.gitignore
> > >  260 programs/rpcss/irot.h
> > >  261 programs/rpcss/irot_s.c
> > >  I think we can safely clean it up, perhaps adding proper line to 
> >  ros-diff,
> > >   but i would like to ask you guys for
> > > confirmation.
> > >  Regards 
> >  
>