Gudie Lines for SVN Write access

[Magnus Olsen]

Hi I should love to see some new gudieles 
how to get svn access. Today it seam anyone
that provide with a patch that is coder can 
getting svn access. But I think we need 
start think how we should handle it,

Here is some ideas how it can be
1. A maling list with patch or in Bugzila
    I love see a maling list with the patch

2.  When people have submit the patch
to us we start examing it see if it any godd
(we are doning that already) 

3. To get SVN write access u need lest 
provide patch in regual basic under 
6 month lest, Then after 6 month the provider
can write to mailing list see if can getting 
SVN write access before he grant SVN 
write access, the full name and mailing 
address must be provided, and we should 
have a vote if that provder can getting 
SVN write access. no accpect from  all 
this rules. 


Yestday some was granted svn access
his name was not on the mailing list
why he got one, he did not write either 
on the mailing list asking for svn access
that why I want see new guide lines how
svn write access handles. so every one 
know how he is and why he was granted
to be granted after few patcher are not
accpect in my eys.  For we are starting
getting alot with people with svn write
access. And new guide lines must be
create. 

BestReagds 
Magnus Olsen

[Casper Hornstrup]

1.	We have a Patches component in Bugzilla for this.
2.	The committer should do minimal testing even if he didn't create the patch. At
least check that ReactOS can still be built
and boot.
3.	It is enough to have a well-known committer recommend you get repository access. This
is usually the person that has
committed most of your patches. I see no reason for this to change since it is simple and
works quite well.

 

I can maintain a page in wiki containing full name and username of each committer if
needed.

 

Btw. Christoph von Wittich has posted to the mailing list several times.

 

Casper

 

  _____  

From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of Magnus
Olsen
Sent: 16. oktober 2005 00:01
To: ReactOS General List; ReactOS Development List
Subject: [ros-dev] Gudie Lines for SVN Write access

 

Hi I should love to see some new gudieles 

how to get svn access. Today it seam anyone

that provide with a patch that is coder can 

getting svn access. But I think we need 

start think how we should handle it,

Here is some ideas how it can be

1. A maling list with patch or in Bugzila
    I love see a maling list with the patch

 

2.  When people have submit the patch

to us we start examing it see if it any godd
(we are doning that already) 

3. To get SVN write access u need lest 
provide patch in regual basic under 

6 month lest, Then after 6 month the provider
can write to mailing list see if can getting 
SVN write access before he grant SVN 

write access, the full name and mailing 

address must be provided, and we should 
have a vote if that provder can getting 
SVN write access. no accpect from  all 

this rules. 

 

Yestday some was granted svn access
his name was not on the mailing list
why he got one, he did not write either 
on the mailing list asking for svn access
that why I want see new guide lines how

svn write access handles. so every one 
know how he is and why he was granted

to be granted after few patcher are not

accpect in my eys.  For we are starting
getting alot with people with svn write
access. And new guide lines must be

create. 

BestReagds 
Magnus Olsen

[Magnus Olsen]

My point is we starting getting alot of people, and yes the currenct rules works but not
for long. 
we are now lest 35 people with commit access.  And we need a system how u getting svn 
access it must be bit harder getting svn write access. 

1. I know we got bugzlla, I wrote Bugzila or mailing list  

2. A patch need always be tested and exaim before it been accpect
I can not count how many time this year I got bad patcher from people
and I need test the code, I got some patcher that doing BSOD in some
case. Yes U need always test and examin the patcher from people that
does not have svn write access. 

3. Not with the time. we are goving alot. We need start thing about futer 
so we do not land up with example over 100 commicters. 

Yes it should be good with full name and commit name on 
reactos website some where. So public can get know how is
how.

I still stand we need these gudlines I worte. 

  ----- Original Message ----- 
  From: Casper Hornstrup 
  To: 'ReactOS Development List' 
  Sent: den 16 October 2005 00:26
  Subject: RE: [ros-dev] Gudie Lines for SVN Write access


    1.. We have a Patches component in Bugzilla for this. 
    2.. The committer should do minimal testing even if he didn't create the patch. At
least check that ReactOS can still be built and boot. 
    3.. It is enough to have a well-known committer recommend you get repository access.
This is usually the person that has committed most of your patches. I see no reason for
this to change since it is simple and works quite well. 
   

  I can maintain a page in wiki containing full name and username of each committer if
needed.

   

  Btw. Christoph von Wittich has posted to the mailing list several times.

   

  Casper

   


------------------------------------------------------------------------------

  From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of
Magnus Olsen
  Sent: 16. oktober 2005 00:01
  To: ReactOS General List; ReactOS Development List
  Subject: [ros-dev] Gudie Lines for SVN Write access

   

  Hi I should love to see some new gudieles 

  how to get svn access. Today it seam anyone

  that provide with a patch that is coder can 

  getting svn access. But I think we need 

  start think how we should handle it,

  Here is some ideas how it can be

  1. A maling list with patch or in Bugzila
      I love see a maling list with the patch

   

  2.  When people have submit the patch

  to us we start examing it see if it any godd
  (we are doning that already) 

  3. To get SVN write access u need lest 
  provide patch in regual basic under 

  6 month lest, Then after 6 month the provider
  can write to mailing list see if can getting 
  SVN write access before he grant SVN 

  write access, the full name and mailing 

  address must be provided, and we should 
  have a vote if that provder can getting 
  SVN write access. no accpect from  all 

  this rules. 

   

  Yestday some was granted svn access
  his name was not on the mailing list
  why he got one, he did not write either 
  on the mailing list asking for svn access
  that why I want see new guide lines how

  svn write access handles. so every one 
  know how he is and why he was granted

  to be granted after few patcher are not

  accpect in my eys.  For we are starting
  getting alot with people with svn write
  access. And new guide lines must be

  create. 

  BestReagds 
  Magnus Olsen

   



------------------------------------------------------------------------------


  _______________________________________________
  Ros-dev mailing list
  Ros-dev(a)reactos.org
  http://www.reactos.org/mailman/listinfo/ros-dev


------------------------------------------------------------------------------


  No virus found in this incoming message.
  Checked by AVG Anti-Virus.
  Version: 7.0.344 / Virus Database: 267.12.0/134 - Release Date: 2005-10-14

[Thomas Weidenmueller]

Magnus Olsen wrote:

>  > My point is we starting getting alot of people,
> and yes the currenct
> > rules works but not for long.
> > we are now lest 35 people with commit access.  And we need a system how
> > u getting svn
> > access it must be bit harder getting svn write access. 

Why make it more difficult? All these people have submitted great
patches in the past. Many of us started like this, why not give others
the same chance?


>  > 2. A patch need always be tested and exaim before
> it been accpect
> > I can not count how many time this year I got bad patcher from people
> > and I need test the code, I got some patcher that doing BSOD in some
> > case. Yes U need always test and examin the patcher from people that
> > does not have svn write access. 

I think that goes without saying...


>  > 3. Not with the time. we are goving alot. We need
> start thing about futer
> > so we do not land up with example over 100 commicters. 

What's so bad about that? That just means that the development speed is
going to increase rapidly  ;)

- Thomas

P.S. having a discussion on two mailing lists is not a good idea I
think, especially when you're subscribed to both lists ;)

[Casper Hornstrup]

Why must it be harder to get repository access? If people can’t commit their

patches themselves then they just send them to Gé and use up all his time.

We can’t have that since we need Gé to merge those Wine patches!

 

Yes, it would be very annoying to have 100 committers rather than our current

35. Then ReactOS would improve much faster ;-)

 

Casper

 

  _____  

From: ros-general-bounces(a)reactos.org [mailto:[e-mail]] On Behalf
Of Magnus Olsen
Sent: 16. oktober 2005 00:56
To: ReactOS Development List
Cc: ReactOS General List
Subject: [ros-general] Re: [ros-dev] Gudie Lines for SVN Write access

 

My point is we starting getting alot of people, and yes the currenct rules works but not
for long. 

we are now lest 35 people with commit access.  And we need a system how u getting svn 

access it must be bit harder getting svn write access. 

1. I know we got bugzlla, I wrote Bugzila or mailing list  

2. A patch need always be tested and exaim before it been accpect
I can not count how many time this year I got bad patcher from people
and I need test the code, I got some patcher that doing BSOD in some
case. Yes U need always test and examin the patcher from people that
does not have svn write access. 

3. Not with the time. we are goving alot. We need start thing about futer 
so we do not land up with example over 100 commicters. 

 

Yes it should be good with full name and commit name on 
reactos website some where. So public can get know how is

how.

 

I still stand we need these gudlines I worte. 

----- Original Message ----- 

From: Casper Hornstrup <mailto:[e-mail]>  

To: 'ReactOS <mailto:[e-mail]>  Development List' 

Sent: den 16 October 2005 00:26

Subject: RE: [ros-dev] Gudie Lines for SVN Write access

 

1.	We have a Patches component in Bugzilla for this. 
2.	The committer should do minimal testing even if he didn’t create the patch. At least
check that ReactOS can still be built
and boot. 
3.	It is enough to have a well-known committer recommend you get repository access. This
is usually the person that has
committed most of your patches. I see no reason for this to change since it is simple and
works quite well. 

 

I can maintain a page in wiki containing full name and username of each committer if
needed.

 

Btw. Christoph von Wittich has posted to the mailing list several times.

 

Casper

 


  _____  


From: ros-dev-bounces(a)reactos.org [mailto:[e-mail]] On Behalf Of Magnus
Olsen
Sent: 16. oktober 2005 00:01
To: ReactOS General List; ReactOS Development List
Subject: [ros-dev] Gudie Lines for SVN Write access

 

Hi I should love to see some new gudieles 

how to get svn access. Today it seam anyone

that provide with a patch that is coder can 

getting svn access. But I think we need 

start think how we should handle it,

Here is some ideas how it can be

1. A maling list with patch or in Bugzila
    I love see a maling list with the patch

 

2.  When people have submit the patch

to us we start examing it see if it any godd
(we are doning that already) 

3. To get SVN write access u need lest 
provide patch in regual basic under 

6 month lest, Then after 6 month the provider
can write to mailing list see if can getting 
SVN write access before he grant SVN 

write access, the full name and mailing 

address must be provided, and we should 
have a vote if that provder can getting 
SVN write access. no accpect from  all 

this rules. 

 

Yestday some was granted svn access
his name was not on the mailing list
why he got one, he did not write either 
on the mailing list asking for svn access
that why I want see new guide lines how

svn write access handles. so every one 
know how he is and why he was granted

to be granted after few patcher are not

accpect in my eys.  For we are starting
getting alot with people with svn write
access. And new guide lines must be

create. 

BestReagds 
Magnus Olsen

 


  _____  


_______________________________________________
Ros-dev mailing list
Ros-dev(a)reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev 


  _____  


No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.344 / Virus Database: 267.12.0/134 - Release Date: 2005-10-14

[Gunnar Dalsnes]

Casper Hornstrup wrote:
>   Yes, it would be very annoying to have 100 committers
> rather than our 
>  current
>  
>  35. Then ReactOS would improve much faster ;-) 
And regress faster too. The wine regression tests should have been run 
automated and Wax was thinking about using winbatch to test real apps.

G.

>   
>   
>  
>  Casper
>

[Ge van Geldorp]

Please read http://www.oreillynet.com/pub/wlg/7996 ("Optimizing for fun").
It gives a few factors that were helpfull in making other open source
projects successfull. One of those factors is "Cast committer rights far and
wide".

I'm not against formalizing the informal rules that we have now (Casper
listed them), but as far as I'm concerned what we have is not broken and
does not need to be fixed.

Gé van Geldorp.

[Martin Fuchs]

On 16.10.2005 00:26:56 Casper Hornstrup wrote:
>   1. We have a Patches component in Bugzilla for this.
>  2. The committer should do minimal testing even if he didn't create the
>   patch. At least check that ReactOS can still be built
>  and boot.
>  3. It is enough to have a well-known committer recommend you get repository
>   access. This is usually the person that has
>   committed most of your patches. I see no reason for this to change since it
>   is simple and works quite well. 
I for my part fully support this statements.

>   I can maintain a page in wiki containing full name and
> username of each
>  committer if needed. 
Yes, this is a good idea.

Regards,

  Martin

[Rick Langschultz]

This is what we do in our environment:
we have a web page where a user can upload their patches via diffs  
or .zip or .tar or .tar.gz files. These files are then unzipped,  
untared, etc. then put into a development binary by a release  
coordinator and a testing coordinator they build the binary and  
distribute a testing release of the program. If more problems occur  
when the patched binaries are commited they are thrown out of the  
binary and put into an "efforts" folder to be evaluated later down  
the development line. Just a thought... Would react have enough space  
to do this???
On Oct 15, 2005, at 5:01 PM, Magnus Olsen wrote:

>   Hi I should love to see some new gudieles
>  how to get svn access. Today it seam anyone
>  that provide with a patch that is coder can
>  getting svn access. But I think we need
>  start think how we should handle it,
>  Here is some ideas how it can be
>  1. A maling list with patch or in Bugzila
>      I love see a maling list with the patch
>
>  2.  When people have submit the patch
>  to us we start examing it see if it any godd
>  (we are doning that already)
>
>  3. To get SVN write access u need lest
>  provide patch in regual basic under
>  6 month lest, Then after 6 month the provider
>  can write to mailing list see if can getting
>  SVN write access before he grant SVN
>  write access, the full name and mailing
>  address must be provided, and we should
>  have a vote if that provder can getting
>  SVN write access. no accpect from  all
>  this rules.
>
>  Yestday some was granted svn access
>  his name was not on the mailing list
>  why he got one, he did not write either
>  on the mailing list asking for svn access
>  that why I want see new guide lines how
>  svn write access handles. so every one
>  know how he is and why he was granted
>  to be granted after few patcher are not
>  accpect in my eys.  For we are starting
>  getting alot with people with svn write
>  access. And new guide lines must be
>  create.
>
>  BestReagds
>  Magnus Olsen
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev 
Rick Langschultz
rlangschultz(a)cox.net (Home)
rlangschultz(a)ellemaespa.com (Work)
rlangschultz(a)email.uophx.edu (School)