Re: [ros-dev] [ros-diffs] [jimtabor] 66244: [NtUser] - Use a real timer for caret. This should cleanup message testing from those random system timer messages. See CORE-7447.

[Hermès BÉLUSCA - MAÏTO]

Hi James!

It would be nice if you could also do some cleanup in that caret code,
because it seems (starting r66244):
- there is somewhat duplicated caret painting in win32k and in user32,
- the caret is sometimes drawn one or two pixels too high.

And of course, everything should be done windows-compatible (not
wine-compatible)!!

Cheers,
Hermès.

------------------------------------------
Author: jimtabor
Date: Fri Feb 13 13:39:57 2015
New Revision: 66244

URL: http://svn.reactos.org/svn/reactos?rev=66244&view=rev
Log:
[NtUser]
- Use a real timer for caret. This should cleanup message testing from those
random system timer messages. See CORE-7447.

Modified:
    trunk/reactos/win32ss/user/ntuser/caret.c

Modified: trunk/reactos/win32ss/user/ntuser/caret.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/caret.c
?rev=66244&r1=66243&r2=66244&view=diff
============================================================================
==
--- trunk/reactos/win32ss/user/ntuser/caret.c	[iso-8859-1] (original)
+++ trunk/reactos/win32ss/user/ntuser/caret.c	[iso-8859-1] Fri Feb 13
13:39:57 2015
@@ -16,6 +16,111 @@
 
 /* FUNCTIONS
*****************************************************************/
 
+VOID FASTCALL
+co_IntDrawCaret(PWND pWnd, PTHRDCARETINFO CaretInfo)
+{

[James Tabor]

Hello!
I've setup sometime next week to do cleanup. Move API hooks and reorder
files.

On Fri, Feb 13, 2015 at 11:02 AM, Hermès BÉLUSCA - MAÏTO <
hermes.belusca(a)sfr.fr&gt; wrote:

>   Hi James!
>
>  It would be nice if you could also do some cleanup in that caret code,
>  because it seems (starting r66244):
>  - there is somewhat duplicated caret painting in win32k and in user32,
>  - the caret is sometimes drawn one or two pixels too high.
>
>  And of course, everything should be done windows-compatible (not
>  wine-compatible)!!
>
>  Cheers,
>  Hermès.
>
>  ------------------------------------------
>  Author: jimtabor
>  Date: Fri Feb 13 13:39:57 2015
>  New Revision: 66244
>
>  URL: http://svn.reactos.org/svn/reactos?rev=66244&view=rev
>  Log:
>  [NtUser]
>  - Use a real timer for caret. This should cleanup message testing from
>  those
>  random system timer messages. See CORE-7447.
>
>  Modified:
>      trunk/reactos/win32ss/user/ntuser/caret.c
>
>  Modified: trunk/reactos/win32ss/user/ntuser/caret.c
>  URL:
>
>  http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/caret.c
>  ?rev=66244&r1=66243&r2=66244&view=diff
>
>  ============================================================================
>  ==
>  --- trunk/reactos/win32ss/user/ntuser/caret.c   [iso-8859-1] (original)
>  +++ trunk/reactos/win32ss/user/ntuser/caret.c   [iso-8859-1] Fri Feb 13
>  13:39:57 2015
>  @@ -16,6 +16,111 @@
>
>   /* FUNCTIONS
>  *****************************************************************/
>
>  +VOID FASTCALL
>  +co_IntDrawCaret(PWND pWnd, PTHRDCARETINFO CaretInfo)
>  +{
>
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>