AbiWord, Worse Written Application

[James Tabor]

Hi!
These are Class Owned DCE starting at the end of allocations. When
closing the application the thread cleanup routine I added frees the
DCE's. (This was not implemented yet, so they never freed and the side
effect of slowing the system down due to hashing the long list of
allocations) Amazing! Look at the count! For every allocation of a
Class Owned DCE there is a menu and even one for every item in the
menu and not reusing the ones allocated and allocating more! This is
one reason AbiWord is slow when drawing! The overhead is crippling!
Most (mean all) applications use one or two DCE's and common to the
DCX_CACHE type. This is the best example of an UNIX ported program to
Windows I've ever seen. Unix hackers hacking it to draw in windows
without the proper research! This is a modest debug list here, what
would happen working with AbiWord all day? ReactOS would most likely
get the blame!  Must I write more?

(subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 152
(subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 153
(subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 154
(dll/win32/gdi32/misc/misc.c:317) Get Handle! Count 1 PEB 0x7ffdf000
(subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 155
(subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 156
(subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 157

[Close App]

err:(dll/win32/user32/windows/menu.c:3687) MenuTrackMenu 2
(subsystems/win32/win32k/ntuser/timer.c:428) Invalid window handle
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
Parent is dead!
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 156
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 155
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 154
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 153
(subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 154
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 153
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 152
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 151
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 150
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 149
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 148
<Snip>.....
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 11
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 10
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 9
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 8
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 7
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 6
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 5
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 4
(subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 3

[Andrew Faulds]

Oh dear. I always didn't like Abiword because it was slow, and now I  
know why.
Also, for once we can blame the developers for it's sluggishness!

Sent from my iPod
Andrew Faulds (andrewweb)

On 28 Jan 2010, at 00:18, James Tabor <jimtabor.rosdev(a)gmail.com> wrote:

>   Hi!
>  These are Class Owned DCE starting at the end of allocations. When
>  closing the application the thread cleanup routine I added frees the
>  DCE's. (This was not implemented yet, so they never freed and the side
>  effect of slowing the system down due to hashing the long list of
>  allocations) Amazing! Look at the count! For every allocation of a
>  Class Owned DCE there is a menu and even one for every item in the
>  menu and not reusing the ones allocated and allocating more! This is
>  one reason AbiWord is slow when drawing! The overhead is crippling!
>  Most (mean all) applications use one or two DCE's and common to the
>  DCX_CACHE type. This is the best example of an UNIX ported program to
>  Windows I've ever seen. Unix hackers hacking it to draw in windows
>  without the proper research! This is a modest debug list here, what
>  would happen working with AbiWord all day? ReactOS would most likely
>  get the blame!  Must I write more?
>
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 152
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 153
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 154
>  (dll/win32/gdi32/misc/misc.c:317) Get Handle! Count 1 PEB 0x7ffdf000
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 155
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 156
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 157
>
>  [Close App]
>
>  err:(dll/win32/user32/windows/menu.c:3687) MenuTrackMenu 2
>  (subsystems/win32/win32k/ntuser/timer.c:428) Invalid window handle
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 156
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 155
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 154
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 153
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 154
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 153
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 152
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 151
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 150
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 149
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 148
>  <Snip>.....
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 11
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 10
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 9
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 8
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 7
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 6
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 5
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 4
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 3
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev

[Olaf Siejka]

Should we let them know?:>

2010/1/28 James Tabor <jimtabor.rosdev(a)gmail.com>

>   Hi!
>  These are Class Owned DCE starting at the end of allocations. When
>  closing the application the thread cleanup routine I added frees the
>  DCE's. (This was not implemented yet, so they never freed and the side
>  effect of slowing the system down due to hashing the long list of
>  allocations) Amazing! Look at the count! For every allocation of a
>  Class Owned DCE there is a menu and even one for every item in the
>  menu and not reusing the ones allocated and allocating more! This is
>  one reason AbiWord is slow when drawing! The overhead is crippling!
>  Most (mean all) applications use one or two DCE's and common to the
>  DCX_CACHE type. This is the best example of an UNIX ported program to
>  Windows I've ever seen. Unix hackers hacking it to draw in windows
>  without the proper research! This is a modest debug list here, what
>  would happen working with AbiWord all day? ReactOS would most likely
>  get the blame!  Must I write more?
>
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 152
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 153
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 154
>  (dll/win32/gdi32/misc/misc.c:317) Get Handle! Count 1 PEB 0x7ffdf000
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 155
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 156
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 157
>
>  [Close App]
>
>  err:(dll/win32/user32/windows/menu.c:3687) MenuTrackMenu 2
>  (subsystems/win32/win32k/ntuser/timer.c:428) Invalid window handle
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/vis.c:75) ATM the Current Window or
>  Parent is dead!
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 156
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 155
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 154
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 153
>  (subsystems/win32/win32k/ntuser/windc.c:96) Alloc DCE's! 154
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 153
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 152
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 151
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 150
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 149
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 148
>  <Snip>.....
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 11
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 10
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 9
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 8
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 7
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 6
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 5
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 4
>  (subsystems/win32/win32k/ntuser/windc.c:640) Freed DCE's! 3
>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>

[James Tabor]

Hi!
Someone should file a bug report. Last bug I filed was for the
GdiFlush abuse, still good example of UNIX hacking....
Thanks,
James

One of these days I'll get around to sending a patch....
http://bugzilla.abisource.com/show_bug.cgi?id=11282

On Thu, Jan 28, 2010 at 2:44 AM, Olaf Siejka <caemyr(a)gmail.com> wrote:
>   Should we let them know?:>
>