Re: [ros-dev] [ros-diffs] [pschweitzer] 65501: [FASTFAT] Set clean shutdown bit on dismount

[Jérôme Gardou]

Hey Pierre!

This flag
>   +    if (DeviceExt->VolumeFcb->Flags &
> VCB_CLEAR_DIRTY)
>  +    {
>  +        /* Set clean shutdown bit */
>  +        Status = GetNextCluster(DeviceExt, 1, &eocMark);
>  +        if (NT_SUCCESS(Status))
>  +        {
>  +            eocMark |= DeviceExt->CleanShutBitMask;
>  +            if (NT_SUCCESS(WriteCluster(DeviceExt, 1, eocMark))) 
and that one
>   +                DeviceExt->VolumeFcb->Flags
> &= ~VCB_IS_DIRTY;
>  +        }
>  +    }
>  +
>       /* Flush volume & files */
>       VfatFlushVolume(DeviceExt, (PVFATFCB)FileObject->FsContext);
>   
>  
>   
don't really seem to match. Or is the former a part of a OR combination
defining the latter ?

Cheers.
Jérôme.

[Pierre Schweitzer]

First flag is set to inform that the second flag is to be removed on
dismount/shutdown.
Hence its removal.

On 11/27/2014 04:14 PM, Jérôme Gardou wrote:
>   Hey Pierre!
>  
>  This flag
> >   +    if (DeviceExt->VolumeFcb->Flags &
> > VCB_CLEAR_DIRTY)
> >  +    {
> >  +        /* Set clean shutdown bit */
> >  +        Status = GetNextCluster(DeviceExt, 1, &eocMark);
> >  +        if (NT_SUCCESS(Status))
> >  +        {
> >  +            eocMark |= DeviceExt->CleanShutBitMask;
> >  +            if (NT_SUCCESS(WriteCluster(DeviceExt, 1, eocMark))) 
>  and that one
> >   +               
> > DeviceExt->VolumeFcb->Flags &= ~VCB_IS_DIRTY;
> >  +        }
> >  +    }
> >  +
> >       /* Flush volume & files */
> >       VfatFlushVolume(DeviceExt, (PVFATFCB)FileObject->FsContext);
> >   
> >
> >  
>  don't really seem to match. Or is the former a part of a OR combination
>  defining the latter ?
>  
>  Cheers.
>  Jérôme.
>  
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>   

-- 
Pierre Schweitzer <pierre(a)reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.