Re: [ros-svn] [gvg] 13073: Implement LOAD_LIBRARY_AS_DATAFILE flag

[Thomas Weidenmueller]

[e-mail] wrote:
> Implement LOAD_LIBRARY_AS_DATAFILE flag

Typecasting PVOID to ULONG isn't portable...ULONG_PTR is supposed to be 
used. Also BOOLEAN should be prefered over BOOL for internal stuff.

Best Regards
Thomas

[Ge van Geldorp]

> From: Thomas Weidenmueller
>
> Typecasting PVOID to ULONG isn't portable...ULONG_PTR is 
> supposed to be used.

Must have missed it somewhere... Looking over the patch again, I see places
where I corrected it but I'm missing again where I introduced it. Can you
point it out to me please?
> Also BOOLEAN should be prefered over BOOL for internal stuff.

Hmm, I thought BOOLEAN was for kernelmode stuff and BOOL for usermode? Then
again, BOOLEAN might be the native type and BOOL the win32 type. Anyone know
for sure?

Gé van Geldorp.

[Thomas Weidenmueller]

Ge van Geldorp wrote:
> Must have missed it somewhere... Looking over the patch again, I see places
> where I corrected it but I'm missing again where I introduced it. Can you
> point it out to me please?

Just look at the diff of res.c...Looking at the entire file there's 
lot's of typecasts to ULONG and arithmetics with pointers that aren't 
portable...
> Hmm, I thought BOOLEAN was for kernelmode stuff and BOOL for usermode? Then
> again, BOOLEAN might be the native type and BOOL the win32 type. Anyone know
> for sure?

AFAIK it should be used in umode and kmode equally, unless defined by 
documentation it should be used for variables and function parameters. 
However it's not really wrong as we do it in many places, I just thought 
i should mention.

Regards,
Thomas

[Ge van Geldorp]

> From: Thomas Weidenmueller
>
> Ge van Geldorp wrote:
> > Must have missed it somewhere... Looking over the patch again, I see 
> > places where I corrected it but I'm missing again where I introduced 
> > it. Can you point it out to me please?
>
> Just look at the diff of res.c...Looking at the entire file there's 
> lot's of typecasts to ULONG and arithmetics with pointers that aren't 
> portable...

Ok, I was under the impression you meant something was wrong with the patch,
but apparently you mean there's room for improvement to the sources as a
whole. You're more than welcome to make these improvements. Maybe we can set
up "janitorial projects" like Wine has?

Gé van Geldorp.

[Steven Edwards]

--- Ge van Geldorp [e-mail] wrote:
> Ok, I was under the impression you meant something was wrong with the patch,
> but apparently you mean there's room for improvement to the sources as a
> whole. You're more than welcome to make these improvements. Maybe we can set
> up "janitorial projects" like Wine has?

One step ahead of you. Just add the info here.

http://mok.lvcm.com/cgi-bin/reactos/roswiki?Janitorial

Thanks
Steven

__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - Helps protect you from nasty viruses. 
http://promotions.yahoo.com/new_mail

[Filip Navara]

Ge van Geldorp wrote:
> Hmm, I thought BOOLEAN was for kernelmode stuff and BOOL for usermode? Then
> again, BOOLEAN might be the native type and BOOL the win32 type. Anyone know
> for sure?

BOOLEAN is the native type and BOOL the win32 type. Also BOOLEAN is 
byte-wide, while BOOL is int.

- Filip