Re: [ros-dev] [ros-diffs] [fireball] 40961: - Initialize IoCountOperations variable to FALSE by default. Spotted by Dmitry Chapyshev & winetests.
Um, there's a serious compiler/linker/loader bug if that value is not already FALSE by default. Best regards, Alex Ionescu
On Sun, May 17, 2009 at 6:46 PM, fireball@svn.reactos.org wrote:
Author: fireball Date: Sun May 17 20:46:58 2009 New Revision: 40961
URL: http://svn.reactos.org/svn/reactos?rev=40961&view=rev Log:
- Initialize IoCountOperations variable to FALSE by default. Spotted by
Dmitry Chapyshev & winetests.
Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c
Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iomgr.c?r...
============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] Sun May 17 20:46:58 2009 @@ -31,7 +31,7 @@ POBJECT_TYPE IoFileObjectType = NULL; extern POBJECT_TYPE IoControllerObjectType; extern UNICODE_STRING NtSystemRoot; -BOOLEAN IoCountOperations; +BOOLEAN IoCountOperations = FALSE; ULONG IoReadOperationCount = 0; LARGE_INTEGER IoReadTransferCount = {{0, 0}}; ULONG IoWriteOperationCount = 0;
It was, sorry, I intended to commit initializing that variable to TRUE and then commit the implementation of the corresponding Ps query information routine.
There is no unified standard on this though, e.g. right the next line forcibly initializes a global var to zero.
WBR, Aleksey.
On May 18, 2009, at 10:25 AM, Alex Ionescu wrote:
Um, there's a serious compiler/linker/loader bug if that value is not already FALSE by default.
Best regards, Alex Ionescu
On Sun, May 17, 2009 at 6:46 PM, fireball@svn.reactos.org wrote: Author: fireball Date: Sun May 17 20:46:58 2009 New Revision: 40961
URL: http://svn.reactos.org/svn/reactos?rev=40961&view=rev Log:
- Initialize IoCountOperations variable to FALSE by default.
Spotted by Dmitry Chapyshev & winetests.
Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c
Modified: trunk/reactos/ntoskrnl/io/iomgr/iomgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/ iomgr/iomgr.c?rev=40961&r1=40960&r2=40961&view=diff ====================================================================== ======== --- trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iomgr.c [iso-8859-1] Sun May 17 20:46:58 2009 @@ -31,7 +31,7 @@ POBJECT_TYPE IoFileObjectType = NULL; extern POBJECT_TYPE IoControllerObjectType; extern UNICODE_STRING NtSystemRoot; -BOOLEAN IoCountOperations; +BOOLEAN IoCountOperations = FALSE; ULONG IoReadOperationCount = 0; LARGE_INTEGER IoReadTransferCount = {{0, 0}}; ULONG IoWriteOperationCount = 0;
-
Aleksey Bragin -
Alex Ionescu