Re: [ros-svn] [ion] 20367: - Major Win32k Header Cleanup: Add ntgdi.h based on latest Platform SDK Public header. It contains the official definitions for NtGdi APIs.

[Hartmut Birr]

ion(a)svn.reactos.com wrote:
>   - Major Win32k Header Cleanup: Add ntgdi.h based on
> latest Platform SDK Public header. It contains the official definitions for NtGdi APIs.
>  - Added ntgdityps.h for structures needed to use the header (which were sadly not
> publically shipped).
>  - Removed internal win32k header data from public headers and put it to internal win32k
> headers.
>  - Fixed ntuser.h STDCALL->WINAPI.
>  - Added ntgdihdl.h for shared GDI Handle information between gdi32/win32k
>  - Added ntusrtyp.h for some shared NtUser types.
>  - Added ntgdibad.h which contains all non-compatible NtGdi prototypes, along with a
> detailed comment for each, and information on how to fix it. I had a 20 000+ line patch
> fixing all these issues, but it contained many bugs and I scrapped it in place for this
> approach, which while dirtier at first, simplifies the number of changes needed so that
> others can work on it as well.
>  - Fixed some gdi32/win32k/user32 header issues.
>
>     
This change breaks running ros on qemu and real hardware. I don't see a
mouse cursor after the gui is started. If I move the mouse, ros does
crash.  If I don't move the mouse, ros starts up to the  first  device
install dialog. After this ros terminates itself and does switch off the
computer.

- Hartmut

(ntoskrnl\mm\mm.c:317) Address: 87dcf974
Unhandled exception
ExceptionCode:    c0000005
Faulting Address: 87dcf974
Address:          77e9238b   C:\ReactOS\system32\user32.dll
CS:EIP 1b:77e9238b
DS 23 ES 23 FS 3b GS 0
EAX: 87dcf974   EBX: 0144fdec   ECX: 0144ffb4
EDX: f000ff53   EBP: 0144fb6c   ESI: 00000000   ESP: 0144fb24
EDI: 00000000   EFLAGS: 00000246
Frames:
   77e50000+2f461      C:\ReactOS\system32\user32.dll
   77e50000+2fdf6      C:\ReactOS\system32\user32.dll
   77e50000+31fb6      C:\ReactOS\system32\user32.dll
   10000000+72cf       C:\ReactOS\system32\win32csr.dll
   77e50000+52657      C:\ReactOS\system32\user32.dll
   77e50000+53a52      C:\ReactOS\system32\user32.dll
   7c900000+a15b       C:\ReactOS\system32\ntdll.dll
   10000000+764e       C:\ReactOS\system32\win32csr.dll
   7c800000+2fe1d      C:\ReactOS\system32\kernel32.dll
(./subsys/win32k/ntuser/window.c:581) thread cleanup: while destroy
wnds, wnd=0x870d11a4
(subsys\win32k\main\dllmain.c:281) thread clean: remove reference obj
0x870d11a4
(subsys\win32k\main\dllmain.c:281) thread clean: remove reference obj
0x870d11a4
KeBugCheckWithTf at ntoskrnl\ke\i386\exp.c:1242
A problem has been detected and ReactOS has been shut down to prevent
damage to your computer.

The problem seems to be caused by the following file: win32k.sys

Technical information:

*** STOP: 0x0000001E (0xc0000005,0x9da2ba1f,0x00000000,0xfffffff4)

***    win32k.sys - Address 0x9da2ba1f base at 0x9d99b000, DateStamp 0x0

Page Fault Exception: 14(0)
Processor: 0 CS:EIP 8:9da2ba1f <win32k.sys:90a1f
(./subsys/win32k/ntuser/msgqueue.c:271 (co_MsqTranslateMouseMessage))>
cr2 fffffff4 cr3 f58c000 Proc: 80ac2050 Pid: 7c <csrss.exe> Thrd:
80c6d220 Tid: b4
DS 23 ES 23 FS 30 GS 0
EAX: fffffff4   EBX: 80c6d5f8   ECX: 00000000
EDX: 9da883d0   EBP: 9e194a8c   ESI: 0164fe24   ESP: 9e1949f0
EDI: 9e194d64   EFLAGS: 00000297 kESP 9e1949f0 kernel stack base 9e192000
Frames:
<win32k.sys:9170b (./subsys/win32k/ntuser/msgqueue.c:621
(co_MsqPeekHardwareMessage))>
<win32k.sys:92bfa (./subsys/win32k/ntuser/msgqueue.c:1259
(co_MsqFindMessage))>
<win32k.sys:88626 (./subsys/win32k/ntuser/message.c:731
(co_IntPeekMessage))>
<win32k.sys:890a3 (./subsys/win32k/ntuser/message.c:941
(co_IntWaitMessage))>
<win32k.sys:893d2 (./subsys/win32k/ntuser/message.c:1051
(NtUserGetMessage))>
<ntoskrnl.exe:9a8ea (ntoskrnl\ke\i386\syscall.S:372 (KiSystemService))>
<user32.dll:52bd3 (lib/user32/windows/message.c:1166 (GetMessageW))>

[WaxDragon]

http://www.reactos.org/bugzilla/show_bug.cgi?id=1208

On 12/28/05, Hartmut Birr <osexpert(a)googlemail.com> wrote:
>   ion(a)svn.reactos.com wrote:
> >   - Major Win32k Header Cleanup: Add ntgdi.h based
> > on latest Platform SDK Public header. It contains the official definitions for NtGdi
> > APIs.
> >  - Added ntgdityps.h for structures needed to use the header (which were sadly not
> > publically shipped).
> >  - Removed internal win32k header data from public headers and put it to internal win32k
> > headers.
> >  - Fixed ntuser.h STDCALL->WINAPI.
> >  - Added ntgdihdl.h for shared GDI Handle information between gdi32/win32k
> >  - Added ntusrtyp.h for some shared NtUser types.
> >  - Added ntgdibad.h which contains all non-compatible NtGdi prototypes, along with a
> > detailed comment for each, and information on how to fix it. I had a 20 000+ line patch
> > fixing all these issues, but it contained many bugs and I scrapped it in place for this
> > approach, which while dirtier at first, simplifies the number of changes needed so that
> > others can work on it as well.
> >  - Fixed some gdi32/win32k/user32 header issues.
> >
> >  
>  This change breaks running ros on qemu and real hardware. I don't see a
>  mouse cursor after the gui is started. If I move the mouse, ros does
>  crash.  If I don't move the mouse, ros starts up to the  first  device
>  install dialog. After this ros terminates itself and does switch off the
>  computer.
>
>  - Hartmut
>
>  (ntoskrnl\mm\mm.c:317) Address: 87dcf974
>  Unhandled exception
>  ExceptionCode:    c0000005
>  Faulting Address: 87dcf974
>  Address:          77e9238b   C:\ReactOS\system32\user32.dll
>  CS:EIP 1b:77e9238b
>  DS 23 ES 23 FS 3b GS 0
>  EAX: 87dcf974   EBX: 0144fdec   ECX: 0144ffb4
>  EDX: f000ff53   EBP: 0144fb6c   ESI: 00000000   ESP: 0144fb24
>  EDI: 00000000   EFLAGS: 00000246
>  Frames:
>     77e50000+2f461      C:\ReactOS\system32\user32.dll
>     77e50000+2fdf6      C:\ReactOS\system32\user32.dll
>     77e50000+31fb6      C:\ReactOS\system32\user32.dll
>     10000000+72cf       C:\ReactOS\system32\win32csr.dll
>     77e50000+52657      C:\ReactOS\system32\user32.dll
>     77e50000+53a52      C:\ReactOS\system32\user32.dll
>     7c900000+a15b       C:\ReactOS\system32\ntdll.dll
>     10000000+764e       C:\ReactOS\system32\win32csr.dll
>     7c800000+2fe1d      C:\ReactOS\system32\kernel32.dll
>  (./subsys/win32k/ntuser/window.c:581) thread cleanup: while destroy
>  wnds, wnd=0x870d11a4
>  (subsys\win32k\main\dllmain.c:281) thread clean: remove reference obj
>  0x870d11a4
>  (subsys\win32k\main\dllmain.c:281) thread clean: remove reference obj
>  0x870d11a4
>  KeBugCheckWithTf at ntoskrnl\ke\i386\exp.c:1242
>  A problem has been detected and ReactOS has been shut down to prevent
>  damage to your computer.
>
>  The problem seems to be caused by the following file: win32k.sys
>
>  Technical information:
>
>  *** STOP: 0x0000001E (0xc0000005,0x9da2ba1f,0x00000000,0xfffffff4)
>
>  ***    win32k.sys - Address 0x9da2ba1f base at 0x9d99b000, DateStamp 0x0
>
>  Page Fault Exception: 14(0)
>  Processor: 0 CS:EIP 8:9da2ba1f <win32k.sys:90a1f
>  (./subsys/win32k/ntuser/msgqueue.c:271 (co_MsqTranslateMouseMessage))>
>  cr2 fffffff4 cr3 f58c000 Proc: 80ac2050 Pid: 7c <csrss.exe> Thrd:
>  80c6d220 Tid: b4
>  DS 23 ES 23 FS 30 GS 0
>  EAX: fffffff4   EBX: 80c6d5f8   ECX: 00000000
>  EDX: 9da883d0   EBP: 9e194a8c   ESI: 0164fe24   ESP: 9e1949f0
>  EDI: 9e194d64   EFLAGS: 00000297 kESP 9e1949f0 kernel stack base 9e192000
>  Frames:
>  <win32k.sys:9170b (./subsys/win32k/ntuser/msgqueue.c:621
>  (co_MsqPeekHardwareMessage))>
>  <win32k.sys:92bfa (./subsys/win32k/ntuser/msgqueue.c:1259
>  (co_MsqFindMessage))>
>  <win32k.sys:88626 (./subsys/win32k/ntuser/message.c:731
>  (co_IntPeekMessage))>
>  <win32k.sys:890a3 (./subsys/win32k/ntuser/message.c:941
>  (co_IntWaitMessage))>
>  <win32k.sys:893d2 (./subsys/win32k/ntuser/message.c:1051
>  (NtUserGetMessage))>
>  <ntoskrnl.exe:9a8ea (ntoskrnl\ke\i386\syscall.S:372 (KiSystemService))>
>  <user32.dll:52bd3 (lib/user32/windows/message.c:1166 (GetMessageW))>
>  _______________________________________________
>  Ros-dev mailing list
>  Ros-dev(a)reactos.org
>  http://www.reactos.org/mailman/listinfo/ros-dev
>  

--
<Russell> argh
<Russell> iterator shenanigans :/

[Maarten Bosma]

Thunk has been broken for 33 hours and Alex was not reachable. So me, 
GreatLord and Fireball agreed
that it should be reverted until it gets fixed and recommitted.

WaxDragon protested but it was just a few seconds too late. However I 
still think that it was the right decision.


Maarten Bosma

WaxDragon wrote:

>  http://www.reactos.org/bugzilla/show_bug.cgi?id=1208
>
> On 12/28/05, Hartmut Birr <osexpert(a)googlemail.com> wrote:
>   
>
> >  ion(a)svn.reactos.com wrote:
> >     
> >
> > >  - Major Win32k Header Cleanup: Add ntgdi.h based
> > > on latest Platform SDK Public header. It contains the official definitions for NtGdi
> > > APIs.
> > > - Added ntgdityps.h for structures needed to use the header (which were sadly not
> > > publically shipped).
> > > - Removed internal win32k header data from public headers and put it to internal win32k
> > > headers.
> > > - Fixed ntuser.h STDCALL->WINAPI.
> > > - Added ntgdihdl.h for shared GDI Handle information between gdi32/win32k
> > > - Added ntusrtyp.h for some shared NtUser types.
> > > - Added ntgdibad.h which contains all non-compatible NtGdi prototypes, along with a
> > > detailed comment for each, and information on how to fix it. I had a 20 000+ line patch
> > > fixing all these issues, but it contained many bugs and I scrapped it in place for this
> > > approach, which while dirtier at first, simplifies the number of changes needed so that
> > > others can work on it as well.
> > > - Fixed some gdi32/win32k/user32 header issues.
> > >
> > >
> > >       
> > >  
> > This change breaks running ros on qemu and real hardware. I don't see a
> > mouse cursor after the gui is started. If I move the mouse, ros does
> > crash.  If I don't move the mouse, ros starts up to the  first  device
> > install dialog. After this ros terminates itself and does switch off the
> > computer.
> >
> > - Hartmut
> >
> > (ntoskrnl\mm\mm.c:317) Address: 87dcf974
> > Unhandled exception
> > ExceptionCode:    c0000005
> > Faulting Address: 87dcf974
> > Address:          77e9238b   C:\ReactOS\system32\user32.dll
> > CS:EIP 1b:77e9238b
> > DS 23 ES 23 FS 3b GS 0
> > EAX: 87dcf974   EBX: 0144fdec   ECX: 0144ffb4
> > EDX: f000ff53   EBP: 0144fb6c   ESI: 00000000   ESP: 0144fb24
> > EDI: 00000000   EFLAGS: 00000246
> > Frames:
> >    77e50000+2f461      C:\ReactOS\system32\user32.dll
> >    77e50000+2fdf6      C:\ReactOS\system32\user32.dll
> >    77e50000+31fb6      C:\ReactOS\system32\user32.dll
> >    10000000+72cf       C:\ReactOS\system32\win32csr.dll
> >    77e50000+52657      C:\ReactOS\system32\user32.dll
> >    77e50000+53a52      C:\ReactOS\system32\user32.dll
> >    7c900000+a15b       C:\ReactOS\system32\ntdll.dll
> >    10000000+764e       C:\ReactOS\system32\win32csr.dll
> >    7c800000+2fe1d      C:\ReactOS\system32\kernel32.dll
> > (./subsys/win32k/ntuser/window.c:581) thread cleanup: while destroy
> > wnds, wnd=0x870d11a4
> > (subsys\win32k\main\dllmain.c:281) thread clean: remove reference obj
> > 0x870d11a4
> > (subsys\win32k\main\dllmain.c:281) thread clean: remove reference obj
> > 0x870d11a4
> > KeBugCheckWithTf at ntoskrnl\ke\i386\exp.c:1242
> > A problem has been detected and ReactOS has been shut down to prevent
> > damage to your computer.
> >
> > The problem seems to be caused by the following file: win32k.sys
> >
> > Technical information:
> >
> > *** STOP: 0x0000001E (0xc0000005,0x9da2ba1f,0x00000000,0xfffffff4)
> >
> > ***    win32k.sys - Address 0x9da2ba1f base at 0x9d99b000, DateStamp 0x0
> >
> > Page Fault Exception: 14(0)
> > Processor: 0 CS:EIP 8:9da2ba1f <win32k.sys:90a1f
> > (./subsys/win32k/ntuser/msgqueue.c:271 (co_MsqTranslateMouseMessage))>
> > cr2 fffffff4 cr3 f58c000 Proc: 80ac2050 Pid: 7c <csrss.exe> Thrd:
> > 80c6d220 Tid: b4
> > DS 23 ES 23 FS 30 GS 0
> > EAX: fffffff4   EBX: 80c6d5f8   ECX: 00000000
> > EDX: 9da883d0   EBP: 9e194a8c   ESI: 0164fe24   ESP: 9e1949f0
> > EDI: 9e194d64   EFLAGS: 00000297 kESP 9e1949f0 kernel stack base 9e192000
> > Frames:
> > <win32k.sys:9170b (./subsys/win32k/ntuser/msgqueue.c:621
> > (co_MsqPeekHardwareMessage))>
> > <win32k.sys:92bfa (./subsys/win32k/ntuser/msgqueue.c:1259
> > (co_MsqFindMessage))>
> > <win32k.sys:88626 (./subsys/win32k/ntuser/message.c:731
> > (co_IntPeekMessage))>
> > <win32k.sys:890a3 (./subsys/win32k/ntuser/message.c:941
> > (co_IntWaitMessage))>
> > <win32k.sys:893d2 (./subsys/win32k/ntuser/message.c:1051
> > (NtUserGetMessage))>
> > <ntoskrnl.exe:9a8ea (ntoskrnl\ke\i386\syscall.S:372 (KiSystemService))>
> > <user32.dll:52bd3 (lib/user32/windows/message.c:1166 (GetMessageW))>
> > _______________________________________________
> > Ros-dev mailing list
> > Ros-dev(a)reactos.org
> > http://www.reactos.org/mailman/listinfo/ros-dev
> >
> >     
> >  
>   
>

[Thomas Weidenmueller]

Hartmut Birr wrote:
>   This change breaks running ros on qemu and real
> hardware. I don't see a
>  mouse cursor after the gui is started. If I move the mouse, ros does
>  crash.  If I don't move the mouse, ros starts up to the  first  device
>  install dialog. After this ros terminates itself and does switch off the
>  computer. 
It's a dependency bug in rbuild. Delete lib/gdi32/misc/win32k.S and
lib/user32/misc/win32k.S and rebuild, that should fix all the problems.
In my opinion those files should be created in obj-i386...

- Thomas

[Thomas Weidenmueller]

Thomas Weidenmueller wrote:
>   Hartmut Birr wrote:
> >   This change breaks running ros on qemu and real
> > hardware. I don't see a
> >  mouse cursor after the gui is started. If I move the mouse, ros does
> >  crash.  If I don't move the mouse, ros starts up to the  first  device
> >  install dialog. After this ros terminates itself and does switch off the
> >  computer. 
>  
>  It's a dependency bug in rbuild. Delete lib/gdi32/misc/win32k.S and
>  lib/user32/misc/win32k.S and rebuild, that should fix all the problems.
>  In my opinion those files should be created in obj-i386... 
Never mind, I didn't notice the patches were reverted in the meanwhile.
Not surprising that it works again ;)

- Thomas