Enabling themes in 3rd stage

[Giannis Adamopoulos]

Hello,
After recent changes in explorer, comctl32 and uxtheme the state of themes in reactos was improved a lot. I would like to ask your opinions about enabling themes in 3rd stage. It is also possible to have an option in 2nd stage to select if we want 3rd stage to have themes enabled. Do you think this should be enabled by default or not? All ideas are welcome. My intention is to complete it ASAP so that it can make in the release.

Thanks,
Giannis Adamopoulos

[encoded]

Add page in 2nd stage setup to select themes

On Mon, Jul 31, 2017 at 10:29 AM, Giannis Adamopoulos <
[e-mail]> wrote:
> Hello,
> After recent changes in explorer, comctl32 and uxtheme the state of themes
> in reactos was improved a lot. I would like to ask your opinions about
> enabling themes in 3rd stage. It is also possible to have an option in 2nd
> stage to select if we want 3rd stage to have themes enabled. Do you think
> this should be enabled by default or not? All ideas are welcome. My
> intention is to complete it ASAP so that it can make in the release.
>
> Thanks,
> Giannis Adamopoulos
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Hermès BÉLUSCA-MAÏTO]

Hi all, that’s good !

I would also prefer a page in 2nd-stage setup where we can choose whether we want to use “classic theme” (aka no theming), or any other theme we may have.

Hermès.

De : Ros-dev [mailto:[e-mail]] De la part de encoded
Envoyé : lundi 31 juillet 2017 16:36
À : ReactOS Development List
Objet : Re: [ros-dev] Enabling themes in 3rd stage

Add page in 2nd stage setup to select themes

On Mon, Jul 31, 2017 at 10:29 AM, Giannis Adamopoulos [e-mail] wrote:

Hello,
After recent changes in explorer, comctl32 and uxtheme the state of themes in reactos was improved a lot. I would like to ask your opinions about enabling themes in 3rd stage. It is also possible to have an option in 2nd stage to select if we want 3rd stage to have themes enabled. Do you think this should be enabled by default or not? All ideas are welcome. My intention is to complete it ASAP so that it can make in the release.

Thanks,
Giannis Adamopoulos

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Dimitrij Klingbeil]

Dear ReactOS developers

While you're at it, implementing a possible additional setting in the 2nd stage installer, could someone please have a look at the keyboard settings in there? The reason I'm asking is because there is a keyboard selection right at the beginning in the text mode installer that seems to get lost later on. No matter which keyboard (assuming non-US) is chosen in the initial stage, it seems not to be properly retained. When the 2nd stage installer fires up and asks for the keyboard settings again, the pre-selected choice is reverted to the default rather than taking over the setting chosen in the text mode - which is rather annoying. I would find it a more user-friendly option if the 2nd (or is it 3rd?) stage installer knew what has already been selected in the text mode stage and if it presented the default choice accordingly.

Thanks and Best regards
Dimitrij
  ----- Original Message ----- 
  From: encoded 
  To: ReactOS Development List 
  Sent: Monday, July 31, 2017 4:35 PM
  Subject: Re: [ros-dev] Enabling themes in 3rd stage

Add page in 2nd stage setup to select themes

On Mon, Jul 31, 2017 at 10:29 AM, Giannis Adamopoulos [e-mail] wrote:

Hello,
    After recent changes in explorer, comctl32 and uxtheme the state of themes in reactos was improved a lot. I would like to ask your opinions about enabling themes in 3rd stage. It is also possible to have an option in 2nd stage to select if we want 3rd stage to have themes enabled. Do you think this should be enabled by default or not? All ideas are welcome. My intention is to complete it ASAP so that it can make in the release.

Thanks,
    Giannis Adamopoulos

_______________________________________________
    Ros-dev mailing list
    [e-mail]
    http://www.reactos.org/mailman/listinfo/ros-dev

------------------------------------------------------------------------------

_______________________________________________
  Ros-dev mailing list
  [e-mail]
  http://www.reactos.org/mailman/listinfo/ros-dev

[Ged Murphy]

Do you have some pics??

I've always been a big fan of seeing the Basic Lite theme being on by default, which would give ros a much more modern look and feel.
We're missing the start menu implementation for this though.

-----Original Message-----
From: Ros-dev [mailto:[e-mail]] On Behalf Of Giannis Adamopoulos
Sent: 31 July 2017 15:29
To: [e-mail]
Subject: [ros-dev] Enabling themes in 3rd stage

Hello,
After recent changes in explorer, comctl32 and uxtheme the state of themes in reactos was improved a lot. I would like to ask your opinions about enabling themes in 3rd stage. It is also possible to have an option in 2nd stage to select if we want 3rd stage to have themes enabled. Do you think this should be enabled by default or not? All ideas are welcome. My intention is to complete it ASAP so that it can make in the release.

Thanks,
Giannis Adamopoulos

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[Ged Murphy]

A link to the theme I mentioned would probably help...
http://aportz19.deviantart.com/art/Basic-Lite-and-Basic-8-Visual-Style-for-W...

-----Original Message-----
From: Ged Murphy [mailto:[e-mail]] 
Sent: 31 July 2017 15:43
To: 'ReactOS Development List' [e-mail]
Subject: RE: [ros-dev] Enabling themes in 3rd stage

Do you have some pics??

I've always been a big fan of seeing the Basic Lite theme being on by default, which would give ros a much more modern look and feel.
We're missing the start menu implementation for this though.

-----Original Message-----
From: Ros-dev [mailto:[e-mail]] On Behalf Of Giannis Adamopoulos
Sent: 31 July 2017 15:29
To: [e-mail]
Subject: [ros-dev] Enabling themes in 3rd stage

Hello,
After recent changes in explorer, comctl32 and uxtheme the state of themes in reactos was improved a lot. I would like to ask your opinions about enabling themes in 3rd stage. It is also possible to have an option in 2nd stage to select if we want 3rd stage to have themes enabled. Do you think this should be enabled by default or not? All ideas are welcome. My intention is to complete it ASAP so that it can make in the release.

Thanks,
Giannis Adamopoulos

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

[David Quintana (gigaherz)]

I have personally always disliked the "Vista Basic" theme. Almost as much
as Luna ;P

On 31 July 2017 at 16:44, Ged Murphy [e-mail] wrote:
> A link to the theme I mentioned would probably help...
> http://aportz19.deviantart.com/art/Basic-Lite-and-Basic-
> 8-Visual-Style-for-Windows-XP-393826050
>
> -----Original Message-----
> From: Ged Murphy [mailto:[e-mail]]
> Sent: 31 July 2017 15:43
> To: 'ReactOS Development List' [e-mail]
> Subject: RE: [ros-dev] Enabling themes in 3rd stage
>
> Do you have some pics??
>
> I've always been a big fan of seeing the Basic Lite theme being on by
> default, which would give ros a much more modern look and feel.
> We're missing the start menu implementation for this though.
>
> -----Original Message-----
> From: Ros-dev [mailto:[e-mail]] On Behalf Of Giannis
> Adamopoulos
> Sent: 31 July 2017 15:29
> To: [e-mail]
> Subject: [ros-dev] Enabling themes in 3rd stage
>
> Hello,
> After recent changes in explorer, comctl32 and uxtheme the state of themes
> in reactos was improved a lot. I would like to ask your opinions about
> enabling themes in 3rd stage. It is also possible to have an option in 2nd
> stage to select if we want 3rd stage to have themes enabled. Do you think
> this should be enabled by default or not? All ideas are welcome. My
> intention is to complete it ASAP so that it can make in the release.
>
> Thanks,
> Giannis Adamopoulos
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Mark Jansen]

I like this theme!

Op 31 jul. 2017 16:44 schreef "Ged Murphy" [e-mail]:
> A link to the theme I mentioned would probably help...
> http://aportz19.deviantart.com/art/Basic-Lite-and-Basic-
> 8-Visual-Style-for-Windows-XP-393826050
>
> -----Original Message-----
> From: Ged Murphy [mailto:[e-mail]]
> Sent: 31 July 2017 15:43
> To: 'ReactOS Development List' [e-mail]
> Subject: RE: [ros-dev] Enabling themes in 3rd stage
>
> Do you have some pics??
>
> I've always been a big fan of seeing the Basic Lite theme being on by
> default, which would give ros a much more modern look and feel.
> We're missing the start menu implementation for this though.
>
> -----Original Message-----
> From: Ros-dev [mailto:[e-mail]] On Behalf Of Giannis
> Adamopoulos
> Sent: 31 July 2017 15:29
> To: [e-mail]
> Subject: [ros-dev] Enabling themes in 3rd stage
>
> Hello,
> After recent changes in explorer, comctl32 and uxtheme the state of themes
> in reactos was improved a lot. I would like to ask your opinions about
> enabling themes in 3rd stage. It is also possible to have an option in 2nd
> stage to select if we want 3rd stage to have themes enabled. Do you think
> this should be enabled by default or not? All ideas are welcome. My
> intention is to complete it ASAP so that it can make in the release.
>
> Thanks,
> Giannis Adamopoulos
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev
>
> Ros-dev mailing list
> [e-mail]
> http://www.reactos.org/mailman/listinfo/ros-dev

[Hermès BÉLUSCA-MAÏTO]

What about the « Whistler » - like theme ? ^^

H.

De : Ros-dev [mailto:[e-mail]] De la part de Mark Jansen
Envoyé : lundi 31 juillet 2017 17:18
À : ReactOS Development List
Objet : Re: [ros-dev] Enabling themes in 3rd stage

I like this theme!

Op 31 jul. 2017 16:44 schreef "Ged Murphy" [e-mail]:

A link to the theme I mentioned would probably help...
http://aportz19.deviantart.com/art/Basic-Lite-and-Basic-8-Visual-Style-for-W...

-----Original Message-----
From: Ged Murphy [mailto:[e-mail]]
Sent: 31 July 2017 15:43
To: 'ReactOS Development List' [e-mail]
Subject: RE: [ros-dev] Enabling themes in 3rd stage

Do you have some pics??

I've always been a big fan of seeing the Basic Lite theme being on by default, which would give ros a much more modern look and feel.
We're missing the start menu implementation for this though.

-----Original Message-----
From: Ros-dev [mailto:[e-mail]] On Behalf Of Giannis Adamopoulos
Sent: 31 July 2017 15:29
To: [e-mail]
Subject: [ros-dev] Enabling themes in 3rd stage

Hello,
After recent changes in explorer, comctl32 and uxtheme the state of themes in reactos was improved a lot. I would like to ask your opinions about enabling themes in 3rd stage. It is also possible to have an option in 2nd stage to select if we want 3rd stage to have themes enabled. Do you think this should be enabled by default or not? All ideas are welcome. My intention is to complete it ASAP so that it can make in the release.

Thanks,
Giannis Adamopoulos

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev

_______________________________________________
Ros-dev mailing list
[e-mail]
http://www.reactos.org/mailman/listinfo/ros-dev