Re: [ros-dev] [ros-diffs] [greatlrd] 33014: fixed pipe working again from cmd more investigate are need it to figout who to really solv bat and pipe and gui apps issue so none regress and working fine in all case. rember gui apps can resive pipe from cmd or send to

[Aleksey]

Any real explanation in the commit message about what was done in this 
commit? Short, real and clean, so every developer reading the commit 
messages could understand what was done and why.

I'm suspicious that it "fixes" one bug, and reopens another.

The same note applies to "start kill the bad macro DXG_GET_INDEX_FUNCTION 
that is instable" (rev. 33012). Macro is a preprocessor definition, it can't 
be stable or not, it's being performed before the actual compile stage. 
Better to explain while enumerating through all functions to find the best 
one is worse than just getting a pointer by indexing. Or why it was done so 
in the beginning.


With the best regards,
Aleksey Bragin.

----- Original Message ----- 
From: <greatlrd(a)svn.reactos.org>
To: <ros-diffs(a)reactos.org>
Sent: Friday, April 18, 2008 4:56 AM
Subject: [ros-diffs] [greatlrd] 33014: fixed pipe working again from cmd 
more investigate are need it to figout who to really solv bat and pipe and 
gui apps issue so none regress and working fine in all case. rember gui apps 
can resive pipe from cmd or send to cmd


>   Author: greatlrd
>  Date: Thu Apr 17 19:56:01 2008
>  New Revision: 33014
>
>  URL: http://svn.reactos.org/svn/reactos?rev=33014&view=rev
>  Log:
>  fixed pipe working again from cmd
>  more investigate are need it to figout who to really solv bat and pipe and 
>  gui apps issue
>  so none regress and working fine in all case. rember gui apps can resive 
>  pipe from cmd or send to cmd