Re: [ros-diffs] [weiden] 13346: 1. fixed InbvPutPixels() to save theebx register which caused bootvid to crash when built withoptimizations

[d_layer]

Hello,

[e-mail] wrote:
> fixed InbvPutPixels() to save the ebx register which caused bootvid
>
> to crash when built with optimizations

You need to save the esi register too.
ebx, esi, edi, and ebp are callee-saved registers in win32/x86.
VC++ and gcc expect external functions not to modify these registers.

http://msdn.microsoft.com/library/en-us/vclang/html/_core_argument_passing_a...
| The compiler generates prolog and epilog code to save and restore
| the ESI, EDI, EBX, and EBP registers, if they are used in the function.
-- 
d_layer

[Thomas Weidenmueller]

d_layer wrote:
> You need to save the esi register too.
> ebx, esi, edi, and ebp are callee-saved registers in win32/x86.
> VC++ and gcc expect external functions not to modify these registers.
>
> http://msdn.microsoft.com/library/en-us/vclang/html/_core_argument_passing_a...
> | The compiler generates prolog and epilog code to save and restore
> | the ESI, EDI, EBX, and EBP registers, if they are used in the function.

Thanks, i fixed it.

Best Regards
Thomas